Add fullScreen function in IFramePlayerOptions for set fs value #926

Praveen-Pable · 2023-02-19T08:57:28Z

Added one method fullScreen in IFramePlayerOptions class for set value of fs parameter.

Add Genius to the apps that are using the library

PierfrancescoSoffritti · 2023-02-19T09:01:24Z

Hi, thanks for the pull request. Can you explain why this is needed?

Praveen-Pable · 2023-02-19T09:03:10Z

Hi, thanks for the pull request. Can you explain why this is needed?

Hi, this function need to display full screen button with normal youtube control. Default value is set to 0.

PierfrancescoSoffritti · 2023-02-19T09:18:25Z

So you want to add this function to be able to see the full screen button? as far as i know the button doesn't work on Android. Did you verify that?

Praveen-Pable · 2023-02-19T09:19:37Z

For more reference, please find below we 2 scenario of fs affect youtube ui. Observe bottom right corner of image for fullscreen button option.

with fs=0	with fs=1

Praveen-Pable · 2023-02-19T09:24:47Z

So you want to add this function to be able to see the full screen button? as far as i know the button doesn't work on Android. Did you verify that?

Yes, you are correct. But still if user want to have that option to display button.
In WebViewYouTubePlayer class, when we set WebChromeClient, we have onShowCustomView and onHideCustomView callback function which helps user to manually handle full screen functionality for youtube video.

PierfrancescoSoffritti · 2023-02-19T09:31:12Z

Interesting, i wasn't aware of WebChromeClient#onShowCustomView. I think it would be really helpful if you could write a new sample activity in the sample app. It would help me and other people understand how to use this.

Praveen-Pable · 2023-02-19T09:33:40Z

Interesting, i wasn't aware of WebChromeClient#onShowCustomView. I think it would be really helpful if you could write a new sample activity in the sample app. It would help me and other people understand how to use this.

Sure, i will create one sample app. Thanks for quick feedback 🙂

Praveen-Pable · 2023-02-19T12:35:20Z

Hi, i have added sample code for full screen. For navigate to sample full screen example, please find 2 option in menu.
Below are some screenshots of sample full screen example:

Portrait	Landscape

Even if button functionality is not working automatically as per expectation but user can mask it and manually handle as per need like i did in above sample.

Please take a look, waiting for your feedback. :)

PierfrancescoSoffritti · 2023-02-19T13:27:24Z

By looking at the sample Activity, it seems like you added a button to the xml, which when clicked changes the orientation of the Activity. It doesn't seem to be related to the full screen button in the IFrame player?

override onShowCustomView and onHideCustomView for webchromeclient

Praveen-Pable · 2023-02-19T13:53:05Z

In latest commit, i have handle event for display full screen video by using of state change.

Portrait	Landscape

Praveen-Pable · 2023-02-19T13:56:11Z

By looking at the sample Activity, it seems like you added a button to the xml, which when clicked changes the orientation of the Activity. It doesn't seem to be related to the full screen button in the IFrame player?

In latest commit, i remove the button. In first example, i try to showcase masking example. And in second example, i try to showcase state handle example.

In second example, IFrame player full screen button icon change in landscape mode as per expectation.

Praveen-Pable · 2023-02-21T08:34:12Z

Hi @PierfrancescoSoffritti , waiting for your feedback. Please let me know if above solution and suggestion looks good or not.

Praveen-Pable · 2023-02-28T08:09:17Z

Hi @PierfrancescoSoffritti, please update. Waiting for your response.

PierfrancescoSoffritti · 2023-02-28T11:06:05Z

Hi thanks for the ping, I will try to have look before the end of the week.

PierfrancescoSoffritti · 2023-03-05T19:14:04Z

...m/pierfrancescosoffritti/androidyoutubeplayer/core/player/listeners/YouTubePlayerListener.kt

@@ -14,7 +15,7 @@ interface YouTubePlayerListener {
 * Called every time the state of the player changes. Check [PlayerConstants.PlayerState] to see all the possible states.
 * @param state a state from [PlayerConstants.PlayerState]
 */
- fun onStateChange(youTubePlayer: YouTubePlayer, state: PlayerConstants.PlayerState)
+ fun onStateChange(youTubePlayer: YouTubePlayer, state: PlayerConstants.PlayerState, view: View? = null)


I find this confusing, why do we need to add a nullable view?

This is problematic for a few reasons:

Is a breaking change. Every user of the library will have to change their implementation of onStateChange

The API is not clear

Maybe this should be a separate method instead?

Changes are made as per suggestion:

Revert code for onStateChange method definition, removed view parameter

Create separate method for handle callback of onShowCustomView and onHideCustomView

PierfrancescoSoffritti · 2023-03-05T19:15:10Z

...src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/PlayerConstants.kt

@@ -3,7 +3,7 @@ package com.pierfrancescosoffritti.androidyoutubeplayer.core.player
 class PlayerConstants {

 enum class PlayerState {
- UNKNOWN, UNSTARTED, ENDED, PLAYING, PAUSED, BUFFERING, VIDEO_CUED
+ UNKNOWN, UNSTARTED, ENDED, PLAYING, PAUSED, BUFFERING, VIDEO_CUED, SHOW_CUSTOM_VIEW, HIDE_CUSTOM_VIEW


These two constants are not related to the state of the player, please move them somewhere else

Changes are made as per suggestion

Remove SHOW_CUSTOM_VIEW and HIDE_CUSTOM_VIEW from PlayerState

Update SimpleFullscreenExampleActivity code accordingly.

1. Revert code for onStateChange method defination, remove view from parameter 2. Remove SHOW_CUSTOM_VIEW and HIDE_CUSTOM_VIEW from PlayerState 3. Create seperate method for handle callback of onShowCustomView and onHideCustomView Also update SimpleFullscreenExampleActivity code accordingly

PierfrancescoSoffritti · 2023-03-10T07:37:30Z

Thanks for updating the change. It is a lot more clear now. Can you please send it to the dev branch instead of master?

I will play with it over the weekend and maybe make some adjustments. Should be merged by Monday :)

PierfrancescoSoffritti · 2023-03-12T18:18:29Z

I've been thinking about this change. As it is it will make things more complicated, because the library already has logic to handle full screen at the view level (instead of webview level). I will need to make more explicit that the current full screen logic is at the view level and will just make the YouTubePlayerView fill its parent. After that is done we can integrate this change.

So it will take a little longer. I'll keep you posted. In the meantime please send the pull request to the dev branch

* Update readme (PierfrancescoSoffritti#875) Add Genius to the apps that are using the library * added mute option * added mute option * changed wording of new method descriptions * removed link in README.md Co-authored-by: Pierfrancesco Soffritti <soffritti.pierfrancesco@gmail.com>

Add FAQ section to README with workarounds

The existing methods to handle full screen mode in `YouTubePlayerView` only change the view’s `LayoutParams` to fill its parent or wrap its content. The naming is misleading because they don’t change the state of the IFrame Player. This change is in preparation of future integration with the full screen state of the IFrame Player. List of main changes in this commit (these are also breaking changes): * Replace YouTubePlayerView#enterFullScreen with YouTubePlayerView#matchParent * Replace YouTubePlayerView#existFullScreen with YouTubePlayerView#wrapContent * Remove YouTubePlayerView#toggleFullScreen * Remove YouTubePlayerView#isFullScreen * Remove `YouTubePlayerFullScreenListener` interface

Add Genius to the apps that are using the library

PierfrancescoSoffritti

lgtm

PierfrancescoSoffritti · 2023-03-14T07:46:26Z

Merged. Thanks @Praveen-Pable for the help!

Praveen-Pable · 2023-03-14T08:02:15Z

Merged. Thanks @Praveen-Pable for the help!

Thanks @PierfrancescoSoffritti for guiding me throughout the process and for valuable feedback. 🙂👍

PierfrancescoSoffritti and others added 2 commits August 7, 2022 09:29

Update readme (PierfrancescoSoffritti#875)

a9b5a70

Add Genius to the apps that are using the library

Add fullScreen function in IFramePlayerOptions for set fs value

fb43b1a

Add sample for simple fullscreen video functionality

f745898

Praveen-Pable added 2 commits February 19, 2023 19:13

add view in onStateChange function parameter declaration

47c68aa

override onShowCustomView and onHideCustomView for webchromeclient

sample full screen example using state change handle

f9df9cf

PierfrancescoSoffritti reviewed Mar 5, 2023

View reviewed changes

Praveen-Pable requested a review from PierfrancescoSoffritti March 8, 2023 08:54

PierfrancescoSoffritti changed the base branch from master to dev March 13, 2023 07:46

S3basuchian and others added 5 commits March 13, 2023 07:58

Add Workarounds To Readme.md (PierfrancescoSoffritti#891)

a64f078

Add FAQ section to README with workarounds

Update FUNDING.yml

4a5505d

Update Gradle Plugin to 7.4.2

9330183

PierfrancescoSoffritti and others added 6 commits March 13, 2023 07:58

Add .idea/ to gitignore

90d1148

Remove .idea folder

3db2996

Update readme (PierfrancescoSoffritti#875) (PierfrancescoSoffritti#931)

7d1d676

Add Genius to the apps that are using the library

Clean up full screen implementation

2ff16ee

Merge branch 'dev' into patch-1

16da8df

Rename example Activity to FullscreenExampleActivity

1a3fcee

PierfrancescoSoffritti approved these changes Mar 14, 2023

View reviewed changes

PierfrancescoSoffritti merged commit 70dc609 into PierfrancescoSoffritti:dev Mar 14, 2023

PierfrancescoSoffritti mentioned this pull request Mar 16, 2023

in XML app:showFullScreenButton is not working #934

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fullScreen function in IFramePlayerOptions for set fs value #926

Add fullScreen function in IFramePlayerOptions for set fs value #926

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023 •

edited

Loading

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 21, 2023

Praveen-Pable commented Feb 28, 2023

PierfrancescoSoffritti commented Feb 28, 2023

PierfrancescoSoffritti Mar 5, 2023

Praveen-Pable Mar 8, 2023

PierfrancescoSoffritti Mar 5, 2023

Praveen-Pable Mar 8, 2023

PierfrancescoSoffritti commented Mar 10, 2023

PierfrancescoSoffritti commented Mar 12, 2023

PierfrancescoSoffritti left a comment

PierfrancescoSoffritti commented Mar 14, 2023

Praveen-Pable commented Mar 14, 2023

Add fullScreen function in IFramePlayerOptions for set fs value #926

Add fullScreen function in IFramePlayerOptions for set fs value #926

Conversation

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

PierfrancescoSoffritti commented Feb 19, 2023 • edited Loading

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 19, 2023

Praveen-Pable commented Feb 21, 2023

Praveen-Pable commented Feb 28, 2023

PierfrancescoSoffritti commented Feb 28, 2023

PierfrancescoSoffritti Mar 5, 2023

Choose a reason for hiding this comment

Praveen-Pable Mar 8, 2023

Choose a reason for hiding this comment

PierfrancescoSoffritti Mar 5, 2023

Choose a reason for hiding this comment

Praveen-Pable Mar 8, 2023

Choose a reason for hiding this comment

PierfrancescoSoffritti commented Mar 10, 2023

PierfrancescoSoffritti commented Mar 12, 2023

PierfrancescoSoffritti left a comment

Choose a reason for hiding this comment

PierfrancescoSoffritti commented Mar 14, 2023

Praveen-Pable commented Mar 14, 2023

PierfrancescoSoffritti commented Feb 19, 2023 •

edited

Loading