Add support for TAG_LongArray #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! Have you done any testing to see that it works? |
|
Also, don't worry too much about the serde code. It's not that hard to add if you know exactly where to look, but that crate is frozen for the moment since it needs to be ported to the post-1.0 API. |
|
Added a brief test case for all three array types, the NBT file in question was generated using the Java game code (via MCP/Forge) |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TAG_LongArray (tag id 12) was introduced somewhere around 1.9/1.10 and
is used in the world format of newer versionswill be used in the world format starting from 1.13 - add support for it.I didn't touch the serde implementation as I'm not familiar enough with serde, so additional changes might be needed there.