Add list palettes and item palette #1190
Open
+179
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argmaster
commented
Mar 11, 2025
IntegratedQuantum
requested changes
Mar 11, 2025
IntegratedQuantum
requested changes
Mar 12, 2025
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
IntegratedQuantum
requested changes
Mar 16, 2025
| if(self.palette.items.len == 0) { | ||
| self.palette.append(allocator.dupe(u8, elem)); | ||
| } | ||
| std.debug.assert(std.mem.eql(u8, self.palette.items[0], elem)); |
There was a problem hiding this comment.
Since you touched this code anyways:
This should probably return an error instead of silently failing in ReleaseFast.
| const self = allocator.create(Palette); | ||
| self.* = Palette{ | ||
| .palette = .init(allocator), | ||
| .palette = .initCapacity(allocator, @max(items.len, 128)), |
There was a problem hiding this comment.
I think you can just use items.len here, the max seems to just adds additional complexity without even giving a clear performance benefit.
I do agree though that it makes sense to use initCapacity when the length is known.
| const translationPalette = main.stackAllocator.alloc(?[]const u8, paletteLength); | ||
| defer main.stackAllocator.free(translationPalette); | ||
|
|
||
| for(translationPalette) |*elem| elem.* = null; |
| if(!zon.get(bool, "hasItem", true)) continue; | ||
| try registerItem(assetFolder, stringId, zon.getChild("item")); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
How difficult would it be to handle id conflicts? (item exists in the blocks folder and in the item folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
item_palette.zig.zonUnfortunately I have developed both features at once sort of my mistake, but they are kind of small so maybe its even better.
Migration for older saves is done by supporting loading from old format and saving only in new format.
Resolves: #1146
Related to: #1125
Related to: #1157