Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd: error notification gui #809

Merged
merged 15 commits into from
Dec 7, 2024
Merged

upd: error notification gui #809

merged 15 commits into from
Dec 7, 2024

Conversation

somanshurath
Copy link
Contributor

@somanshurath somanshurath commented Dec 4, 2024 •
edited
Loading

Fixes #810
Update: Error Notification GUI added.
Fixes #815
Fix: Revert global state on receiving error...

@IntegratedQuantum
Copy link
Member

Pro-tip: You don't need to reopen the PR if you make changes, the PR automatically includes any changes to the underlying branch.

@IntegratedQuantum IntegratedQuantum mentioned this pull request Dec 4, 2024
Closed
IntegratedQuantum
IntegratedQuantum requested changes Dec 4, 2024
View reviewed changes
src/gui/windows/multiplayer.zig Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
@somanshurath
Copy link
Contributor Author

fixes #810

IntegratedQuantum
IntegratedQuantum requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #810

Please edit this into the PR post. Github doesn't pick up these hints from regular comments.

src/gui/GuiWindow.zig Outdated Show resolved Hide resolved
src/gui/gui.zig Outdated Show resolved Hide resolved
src/gui/gui.zig Outdated Show resolved Hide resolved
src/gui/gui.zig Outdated Show resolved Hide resolved
src/gui/windows/_windowlist.zig Outdated Show resolved Hide resolved
src/gui/gui.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
IntegratedQuantum
IntegratedQuantum requested changes Dec 4, 2024
View reviewed changes
src/gui/windows/_windowlist.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
@somanshurath somanshurath changed the title fix: empty host ip in multiplayer upd: error notification gui and network checks Dec 5, 2024
@somanshurath somanshurath changed the title upd: error notification gui and network checks upd: error notification gui Dec 5, 2024
IntegratedQuantum
IntegratedQuantum requested changes Dec 5, 2024
View reviewed changes
src/gui/gui.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
IntegratedQuantum added a commit that referenced this pull request Dec 5, 2024
@IntegratedQuantum
Fix some problems with window closing and the delete world confirmati…
c495e84 
…on window.

Seems relevant for #809
@IntegratedQuantum
Copy link
Member

It seems that window closing was kind of broken, so may need to rebase to get my last commit from master.
If you are stuck, you can also look into how the delete_world_confirmation works, it uses a similar pattern when opened from the save_selection gui.

IntegratedQuantum
IntegratedQuantum requested changes Dec 6, 2024
View reviewed changes
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
IntegratedQuantum
IntegratedQuantum requested changes Dec 7, 2024
View reviewed changes
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine now, just two more small things and then we can merge this.

Thanks for taking the time to make this work for other wrong address patterns as well.

this resolves #815 as well then...

Also again please put this in the PR post, so github automatically closes the issue on merge.

src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
src/gui/windows/multiplayer.zig Outdated Show resolved Hide resolved
@IntegratedQuantum IntegratedQuantum merged commit 3d67c90 into PixelGuys:master Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IntegratedQuantum IntegratedQuantum IntegratedQuantum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiplayer Network Error Handling Add an error notification window
2 participants
@somanshurath @IntegratedQuantum