Refactorisation + Intégration travail des perfs #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandine-sahl
force-pushed
the
workshop_filename_generation
branch
3 times, most recently
from
d913752 to
768b2ce
Compare
mvergez
requested changes
May 11, 2023
amandine-sahl
force-pushed
the
workshop_filename_generation
branch
2 times, most recently
from
750d2d3 to
0bb5c42
Compare
amandine-sahl
force-pushed
the
workshop_filename_generation
branch
from
0bb5c42 to
f26768b
Compare
bouttier
reviewed
May 12, 2023
| skip_newer_than=scheduled_export.frequency * 24 * 60, | ||
| export_id=export_request.export.id, | ||
| file_name=export_request.generate_file_name(), | ||
| export_url=None, |
There was a problem hiding this comment.
Voir si on ne peut pas mettre la génération de export_url dans ExportRequest
|
|
||
| return full_file_name | ||
| def __init__(self, id_export, scheduled_export=None, user=None, format=None): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, id_export, scheduled_export=None, user=None, format=None): | |
| def __init__(self, id_export, user=None, format=None): |
| conf = current_app.config.get("EXPORTS") | ||
| def generate_file_name(self): | ||
| if self.file_name: | ||
| return Path(self.export_dir) / self.file_name |
| export=export, user=id_role, export_url=export_url, export_failed=True | ||
| ) | ||
| raise exp | ||
| notify_export_file_generated(export=export, user=id_role, export_url=export_url) |
There was a problem hiding this comment.
Suggested change
| notify_export_file_generated(export=export, user=id_role, export_url=export_url) | |
| else: | |
| notify_export_file_generated(export=export, user=id_role, export_url=export_url) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactorisation du module.
Suppression des paramètres de configs :
usr_generated_dirname: chemin absolu ou relatif au dossier media du dossier où les exports à la demande des utilisateurs seront déposésexport_schedules_dir: chemin absolu ou relatif au dossier media du dossier où les exports programmés seront déposésexport_web_url