-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ExportRequest #166
Conversation
b9b8e3c
to
ac4bd49
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## workshop #166 +/- ##
============================================
+ Coverage 53.52% 61.13% +7.60%
============================================
Files 12 11 -1
Lines 680 669 -11
============================================
+ Hits 364 409 +45
+ Misses 316 260 -56
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
9f70f4a
to
0bf291d
Compare
6ebcb62
to
9d777be
Compare
raise ExportGenerationNotNeeded(self.export.id, self.skip_newer_than - age) | ||
|
||
def get_export_url(self): | ||
with current_app.test_request_context(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
À priori c’est pas fait pour ça test_request_context
! C’est quoi le soucis qui t’as amené à devoir le mettre ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est l'usage d'url_for qui ne peut être appeler que dans le contexte d'une requête. Sauf si on lui spécifie le SERVER_NAME.
https://flask.palletsprojects.com/en/2.3.x/api/#flask.Flask.url_for
c0fca8c
to
dc59527
Compare
…ompte également pour export utilisateur) Change url_for test task and commands Test generate schedule
dc59527
to
423d835
Compare
Prise en compte remarque PR #155
Ajout paramètre --skip-newer-than et utilisation de ce dernière pour les fichiers non scheduler