Fix #244: Disable buffer for comments #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments for an episode are sent back to the front end using chunked Transfer Enconding, but that that is not supported on HTTP/2 which is used by the reverse proxy (nginx).
At the moment nginx buffers the chunks before sending them to the browser, which breaks the way the chunks are processed.
With this commit, we use the header
X-Accel-Buffering
to disable this buffering, which worked in local testing.We should still add a more clear chunk delimiter so that any other buffering or unknown edge case will not
break the comments function (increase robustness).
Co-authored-by: @ericpp
Fixes #244