Refactoring #244 - Comments robustness #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a refactoring on the Comments function to improve robustness for loading partial responses form the comments API. Once we introduced partial responses (i.e. chunked encoding), it worked in dev, but failed in production due to buffering in the reverse proxy (nginx). This was already solved with Podcastindex-org#247, but only if the reverse proxy remains unchanged. With this refactoring, the implementation would continue to work even if buffering took place, making it more robust. For testing, the change introduced in the PR mentioned above was reverted (temporarily). For additinal testing instructions, see Podcastindex-org#247 (comment)
|
@ericpp , you may want to take a look at this PR. |
|
@dellagustin I can take a look at it. Here was my approach before finding the Nginx header: ericpp@2ffe5c4 |
|
@dellagustin Looks good to me. I tested it out with 512, 1k, and 8k Nginx buffer sizes and they all worked great! |
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a refactoring on the Comments function to improve robustness for loading partial responses form the comments API.
Once we introduced partial responses (i.e. chunked encoding), it worked in dev, but failed in production due to buffering in the reverse proxy (nginx).
This was already solved with
#247, but only if the reverse proxy remains unchanged.
With this refactoring, the implementation would continue to work even if buffering took place, making it more robust.
For testing, the change introduced in the PR mentioned above was reverted (temporarily).
For additinal testing instructions, see
#247 (comment)