Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows pcl_registration project build errors: error C2487 'pcl::Registration<...>::setInputSource(...): member of dll interface class may not be declared with dll interface #996

Closed
magro11 opened this issue Nov 13, 2014 · 1 comment

Comments

@magro11
Copy link

magro11 commented Nov 13, 2014

This is a similar issue than #426:

When building the current master of PCL with MSVC2010, 32bit, the pcl_registration project fails to build due to the error message indicated in the title.

I tried to find the problem and noticed that (similar to #426, too) deleting the line

using Registration<PointSource, PointTarget, Scalar>::setInputSource;

in icp.h (class IterativeClosestPoint) solved the issue and the project compiled properly. The problem seems to be that setInputSource(...) in the base class pcl::Registration is a virtual function, this does not work with the using... command. For other methods that are not virtual the using command does not cause any compiler errors.

What is the initial intention of the using command in icp.h? Is it allowed to simply delete the indicated line?

Cheers
Marc

@taketwo
Copy link
Member

taketwo commented Nov 22, 2014

What is the initial intention of the using command in icp.h? Is it allowed to simply delete the indicated line?

Can not say anything about the intention, but it should be safe to remove it. Note that for a sibling function setInputTarget() there is no using declaration whatsoever and it works fine.

Please send a pull request with the change. Thanks!

taketwo added a commit that referenced this issue Nov 24, 2014
fixes MSVC compiler error C2487. Fix for issue #996.
@taketwo taketwo closed this as completed Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants