Add missing typedefs to PointCloud for stl container compatibility #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was being pedantically strict on the "no public api changes on the minor versions", but totally open to discussion. Opinions @jspricke and @VictorLamoine ? |
|
The problem are not API but ABI changes and these are only typedefs, so I don't see a problem, |
|
👍 |
SergioRAgostinho
removed
the
needs: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I added some typedefs to the PointCloud class, which should enable it to be used with more stl algorithms. This patch originates in the following pcl-users thread where sb. wanted to copy the fields of a point cloud A into a point cloud C, but only if the xyz value was in a point cloud B.
Instead of doing that manually in a loop I thought why not use stl methods for that, specifically set_intersection. There I ran into compilation problems originating in these missing typedefs. With this patch, the example compiles and works as expected.
Best,
Stefan