Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the build of ndt_2d with Eigen 3.3 #1821

Merged
merged 1 commit into from
May 30, 2017

Conversation

bouffa
Copy link
Contributor

@bouffa bouffa commented Feb 19, 2017

@jspricke
Copy link
Member

Hi Mourad, great to see you here :). Looking at Eigen, shouldn't it be rather PointT instead of double? On the other side, Real is the same, so +1 from me.

@bouffa
Copy link
Contributor Author

bouffa commented Feb 20, 2017

Hi Jochen, thanks :)

According to Eigen::NumTraits< T > Class Template Reference , Literal should be a numeric type :

A typedef Literal giving the type to use for numeric literals such as "2" or "0.5". For instance, for std::complex, Literal is defined as U. Of course, this type must be fully compatible with T. In doubt, just use T here.

@@ -358,6 +358,7 @@ namespace Eigen
template<typename PointT> struct NumTraits<pcl::ndt2d::NormalDist<PointT> >
{
typedef double Real;
typedef double Literal;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not typedef PointT Literal; ?

@jspricke jspricke merged commit f3c8114 into PointCloudLibrary:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants