Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the whole codebase #2217

Merged
merged 5 commits into from
Feb 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2d/include/pcl/2d/edge.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ namespace pcl
/** \brief This function suppresses the edges which don't form a local maximum
* in the edge direction.
* \param[in] edges point cloud containing all the edges
* \param[out] maxima point cloud containing the non-max supressed edges
* \param[out] maxima point cloud containing the non-max suppressed edges
* \param[in] tLow
*/
void
Expand Down
10 changes: 5 additions & 5 deletions 2d/include/pcl/2d/impl/morphology.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ pcl::Morphology<PointT>::erosionBinary (pcl::PointCloud<PointT> &output)
{
continue;
}
// If one of the elements of the kernel and image dont match,
// If one of the elements of the kernel and image don't match,
// the output image is 0. So, move to the next point.
if ((*input_)(j + l - kernel_width / 2, i + k - kernel_height / 2).intensity != 1)
{
Expand Down Expand Up @@ -192,7 +192,7 @@ pcl::Morphology<PointT>::erosionGray (pcl::PointCloud<PointT> &output)
{
continue;
}
// If one of the elements of the kernel and image dont match,
// If one of the elements of the kernel and image don't match,
// the output image is 0. So, move to the next point.
if ((*input_)(j + l - kernel_width / 2, i + k - kernel_height / 2).intensity < min || min == -1)
{
Expand Down Expand Up @@ -236,7 +236,7 @@ pcl::Morphology<PointT>::dilationGray (pcl::PointCloud<PointT> &output)
{
continue;
}
// If one of the elements of the kernel and image dont match,
// If one of the elements of the kernel and image don't match,
// the output image is 0. So, move to the next point.
if ((*input_)(j + l - kernel_width / 2, i + k - kernel_height / 2).intensity > max || max == -1)
{
Expand Down Expand Up @@ -277,7 +277,7 @@ pcl::Morphology<PointT>::subtractionBinary (
const pcl::PointCloud<PointT> &input1,
const pcl::PointCloud<PointT> &input2)
{
const int height = (input1.height < input2.hieght) ? input1.height : input2.height;
const int height = (input1.height < input2.height) ? input1.height : input2.height;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review

const int width = (input1.width < input2.width) ? input1.width : input2.width;
output.width = width;
output.height = height;
Expand All @@ -299,7 +299,7 @@ pcl::Morphology<PointT>::unionBinary (
const pcl::PointCloud<PointT> &input1,
const pcl::PointCloud<PointT> &input2)
{
const int height = (input1.height < input2.hieght) ? input1.height : input2.height;
const int height = (input1.height < input2.height) ? input1.height : input2.height;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review

const int width = (input1.width < input2.width) ? input1.width : input2.width;
output.width = width;
output.height = height;
Expand Down
22 changes: 11 additions & 11 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@
* Removed unnecessary mutex locking in `TimeTrigger::registerCallback`
[[#1087]](https://github.com/PointCloudLibrary/pcl/pull/1087)
* Updated PCL exception types to have nothrow copy constructor and copy
assigment operator
assignment operator
[[#1119]](https://github.com/PointCloudLibrary/pcl/pull/1119)
* Fixed a bug with `PCA` not triggering recomputation when input indices are
changed
Expand Down Expand Up @@ -625,7 +625,7 @@
* Added a new `MetaRegistration` class that allows to register a stream of
clouds where each cloud is aligned to the conglomerate of all previous clouds
[[#1426]](https://github.com/PointCloudLibrary/pcl/pull/1426)
* Fixed segmentation fault occuring in `CorrespondenceRejectorSurfaceNormal`
* Fixed segmentation fault occurring in `CorrespondenceRejectorSurfaceNormal`
[[#1536]](https://github.com/PointCloudLibrary/pcl/pull/1536)
* Use aligned allocator in vectors of MatchingCandidate
[[#1552]](https://github.com/PointCloudLibrary/pcl/pull/1552)
Expand Down Expand Up @@ -1381,13 +1381,13 @@ The most notable overall changes are:
* Added a setDimension function to concave hull, so users can specify desired dimensionality of the resulting hull. If no dimension is specified, one will be automatically determined.
* Fixed bug #692 - MovingLeastSquares indices issues
* Added curve fitting and trimming of surfaces to examples/surface/example_nurbs_fitting_surface.cpp
* Added iterative fitting routines for curve fitting surface::on_nurbs::Triangulation - added convertion functions for nurbs curve to line-polygon - added convertion functions for nurbs surface and curve to PolyMesh
* Added iterative fitting routines for curve fitting surface::on_nurbs::Triangulation - added conversion functions for nurbs curve to line-polygon - added conversion functions for nurbs surface and curve to PolyMesh
* Added flag to enable/disable usage of UmfPack for fast solving of sparse systems of equations - added triangulation functions to convert ON_NurbsSurface to pcl::PolygonMesh
* Added bug fix in ConcaveHull, thanks to summer.icecream
* Added marching cubes using RBF and Hoppe SDF
* Pushed new functions that perform texture-mapping on meshes.
* Fix: issue #646 (vtk_smoothing not copied)
* Added new functionalities to TextureMapping: Find occlusions based on raytracing in octrees, UV mapping based on Texture resolution and camera focal lenght.
* Added new functionalities to TextureMapping: Find occlusions based on raytracing in octrees, UV mapping based on Texture resolution and camera focal length.
* Relaxing dimensionality check threshold on concave_hull, so that 3D hulls should no longer be calculated on 2D input.
* Added poisson filter

Expand Down Expand Up @@ -1629,7 +1629,7 @@ The most notable overall changes are:
* added a normal space sampling filter
* fixed bug #433: `pcl::CropBox` doesn't update `width` and `height` member of output point cloud
* fixed bug #423 `CropBox` + `VoxelGrid` filters, order changes behaviour (using openni grabber)
* add `CropHull` filter for filtering points based on a 2D or 3D convex or concave hull. The ray-polygon intersection test is used, which relys on closed polygons/surfaces
* add `CropHull` filter for filtering points based on a 2D or 3D convex or concave hull. The ray-polygon intersection test is used, which relies on closed polygons/surfaces
* added clipper3D interface and a draft plane_clipper3D implementation
* removed spurious old `ColorFilter` class (obsolete, and it was never implemented - the skeleton was just lurking around)
* better Doxygen documentation to `PassThrough`, `VoxelGrid` and `Filter`
Expand Down Expand Up @@ -1683,7 +1683,7 @@ The most notable overall changes are:
### `lipcl_keypoints`

* added refine method for `Harris3D` corner detector
* rewrote big parts of the NARF keypoint extraction. Hopfully fixing some stability issues. Unfortunately still pretty slow for high resolution point clouds.
* rewrote big parts of the NARF keypoint extraction. Hopefully fixing some stability issues. Unfortunately still pretty slow for high resolution point clouds.
* fixed bug #461 (SIFT Keypoint result cloud fields not complete); cleaned up the line-wrapping in the error/warning messages

### `libpcl_surface`
Expand Down Expand Up @@ -1827,7 +1827,7 @@ pcl::OrganizedDataIndex -> pcl::search::OrganizedNeighbor
* fixed a bug in `getRejectedQueryIndices`, wrong output when order of correspondences have been changed
* moved `getRejectedQueryIndices` to pcl/common/correspondence.h
* added more doxygen documentation to the registration components
* marked all `getRemainingCorrespondences`-functions as DEPRECATED, we sould replace them with purely stateless version outside the class body
* marked all `getRemainingCorrespondences`-functions as DEPRECATED, we should replace them with purely stateless version outside the class body
* fixed a const missing in `PolynomialCalculationsT` (#388 - thanks Julian!)
* add `PCL_DEPRECATED` macro, closes #354.
* added `PointXYZHSV` type and the conversions for it
Expand Down Expand Up @@ -1913,7 +1913,7 @@ pcl::OrganizedDataIndex -> pcl::search::OrganizedNeighbor
* fixed bug in getRejectedQueryIndices, wrong output when order of correspondences have been changed
* moved getRejectedQueryIndices to pcl/common/correspondence.h
* added more doxygen documentation to the registration components
* marked all "getRemainingCorrespondences"-functions as DEPRECATED, we sould replace them with purely stateless version outside the class body
* marked all "getRemainingCorrespondences"-functions as DEPRECATED, we should replace them with purely stateless version outside the class body
* Update: remove ciminpack dependency and rely on eigen for LM
* Fixed a bug in ICP-NL by modifying `WarpPointRigid` to preserve the value of the 4th coordinate when warping; Re-enabled missing unit tests for ICP and ICP-NL
* Added point-to-plane ICP
Expand Down Expand Up @@ -2306,7 +2306,7 @@ The version numbers below belong to the *perception_pcl* stack in ROS, which coo
* added a new generalized field value filter (_pcl::ConditionalRemoval_)
* cleaned up normal estimation through integral images
* PCL rift.hpp and point_types.hpp fixed for Windows/VS2010
* fixed all _is_dense_ occurances
* fixed all _is_dense_ occurrences
* *unmanged all _Eigen3::_ calls to _Eigen::_*
* changed all _!isnan_ checks to _isfinite_ in order to catch INF/-INF values
* added vtk_io tools for saving VTK data from _PolygonMesh_ structures
Expand Down Expand Up @@ -2341,7 +2341,7 @@ The version numbers below belong to the *perception_pcl* stack in ROS, which coo
* Added Correspondence as a structure representing correspondences/matches (similar to OpenCV's DMatch) containing query and match indices as well as the distance between them respective points.
* Added _CorrespondenceEstimation_ for determining closest point correspondence, feature correspondences and reciprocal point correspondences.
* Added _CorrespondenceRejection_ and derivations for rejecting correspondences, e.g., based on distance, removing 1-to-n correspondences, RANSAC-based outlier removal (+transformation estimation).
* Further splitted up registration.h and added transformation estimation classes, e.g., for estimating rigid transformation using SVD.
* Further split up registration.h and added transformation estimation classes, e.g., for estimating rigid transformation using SVD.
* Added ```sensor_msgs::Image image; pcl::toROSMsg (cloud, image);```See tools/convert_pcd_image.cpp for a sample.
* Added a new point type, _PointWithScale_, to store the output of _SIFTKeypoint_ detection.
* Fixed a minor bug in the error-checking in _SIFTKeypoint::setScales(...)_
Expand Down Expand Up @@ -2395,7 +2395,7 @@ The version numbers below belong to the *perception_pcl* stack in ROS, which coo
* Added RSD (Radius Signature Descriptor) feature.
* Updated the entire PCL tree to use FLANN as a default _KdTree_
* Optimized the _KdTreeFLANN::radiusSearch_ so it doesn't do any memory allocation if the indices and distances vectors passed in are pre-allocated to the point cloud size.
* Changed _KdTree::radiusSearch_ method signature to return int (number of neighbors found) intead of bool
* Changed _KdTree::radiusSearch_ method signature to return int (number of neighbors found) instead of bool
* added new _pcl::View<T>_ class that holds a _PointCloud_, an _Image_, and a _CameraInfo_ message (r34575)
* Moving the _Surface_ reconstruction framework to the new structure (r34547)
* Moving the _Segmentation_ framework to the new structure (r34546)
Expand Down
2 changes: 1 addition & 1 deletion PCLConfig.cmake.in
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ endmacro(find_glew)
# |--> _lib is optional ==> disable it (thanks to the guardians)
# | and warn
# `--> _lib is required
# |--> component is required explicitely ==> error
# |--> component is required explicitly ==> error
# `--> component is induced ==> warn and remove it
# from the list

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ namespace pcl

if (out->points.size () == 0)
{
PCL_WARN("NORMAL estimator: Cloud has no points after voxel grid, wont be able to compute normals!\n");
PCL_WARN("NORMAL estimator: Cloud has no points after voxel grid, won't be able to compute normals!\n");
return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ namespace pcl

/**
* \brief Initializes the FLANN structure from the provided source
* It does training for the models that havent been trained yet
* It does training for the models that haven't been trained yet
*/

void
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ namespace pcl
/** \brief Stores the state of the current tree view in item_treestate_map_ */
void
storeTreeState ();
/** \brief Retores the state of \param model 's view from item_treestate_map_ */
/** \brief Restores the state of \param model 's view from item_treestate_map_ */
void
restoreTreeState ();
/** \brief Removes the extra tabs the item might have */
Expand Down
2 changes: 1 addition & 1 deletion apps/cloud_composer/src/commands.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ pcl::cloud_composer::MergeCloudCommand::redo ()
{
qDebug () << "Redo in MergeCloudCommand ";
last_was_undo_ = false;
//There is only one output_pair, but thats ok
//There is only one output_pair, but that's ok
foreach (OutputPair output_pair, output_data_)
{
//Replace the input with the output for this pair
Expand Down
2 changes: 1 addition & 1 deletion apps/cloud_composer/src/items/cloud_item.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ pcl::cloud_composer::CloudItem::removeFromView (boost::shared_ptr<pcl::visualiza
QVariant
pcl::cloud_composer::CloudItem::data (int role) const
{
// Check if we're trying to get something which is template dependant, if so, create the template if it hasn't been set
// Check if we're trying to get something which is template dependent, if so, create the template if it hasn't been set
if ( (role == ItemDataRole::CLOUD_TEMPLATED || role == ItemDataRole::KD_TREE_SEARCH) && !template_cloud_set_)
{
qCritical () << "Attempted to access templated types which are not set!!";
Expand Down
2 changes: 1 addition & 1 deletion apps/cloud_composer/src/items/fpfh_item.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pcl::cloud_composer::FPFHItem::getInspectorTabs ()
{


//Create the plotter and QVTKWidget if it doesnt exist
//Create the plotter and QVTKWidget if it doesn't exist
if (!plot_)
{
plot_ = boost::shared_ptr<pcl::visualization::PCLPlotter> (new pcl::visualization::PCLPlotter);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pcl::cloud_composer::SelectionEvent::~SelectionEvent ()
void
pcl::cloud_composer::SelectionEvent::findIndicesInItem (CloudItem* cloud_item, pcl::PointIndices::Ptr indices)
{
// WE DONT NEED TO DO THIS SEARCH BECAUSE WE HAVE A 1-1 CORRESPONDENCE VTK TO PCL
// WE DON'T NEED TO DO THIS SEARCH BECAUSE WE HAVE A 1-1 CORRESPONDENCE VTK TO PCL
// THIS IS ONLY THE CASE FOR CLOUDS WITH NO NANs
//Go through every point in the selected data set and find the matching index in this cloud
//pcl::search::KdTree<pcl::PointXYZ>::Ptr search = cloud_item->data (KD_TREE_SEARCH).value <pcl::search::Search<pcl::PointXYZ>::Ptr> ();
Expand Down
2 changes: 1 addition & 1 deletion apps/include/pcl/apps/dominant_plane_segmentation.h
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ namespace pcl
return 1;
else
{
//compute distance and check aginst max_dist
//compute distance and check against max_dist
if ((p1.getVector3fMap () - p2.getVector3fMap ()).norm () <= max_dist)
{
p2.intensity = p1.intensity;
Expand Down
2 changes: 1 addition & 1 deletion apps/include/pcl/apps/pcd_video_player.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class PCDVideoPlayer : public QMainWindow
/** \brief Indicate that the timeoutSlot needs to reload the pointcloud */
bool cloud_modified_;

/** \brief Indicate that files should play continiously */
/** \brief Indicate that files should play continuously */
bool play_mode_;
/** \brief In play mode only update if speed_counter_ == speed_value */
unsigned int speed_counter_;
Expand Down
12 changes: 6 additions & 6 deletions apps/include/pcl/apps/render_views_tesselated_sphere.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace pcl
{
namespace apps
{
/** \brief @b Class to render synthetic views of a 3D mesh using a tesselated sphere
/** \brief @b Class to render synthetic views of a 3D mesh using a tessellated sphere
* NOTE: This class should replace renderViewTesselatedSphere from pcl::visualization.
* Some extensions are planned in the near future to this class like removal of duplicated views for
* symmetrical objects, generation of RGB synthetic clouds when RGB available on mesh, etc.
Expand Down Expand Up @@ -70,7 +70,7 @@ namespace pcl
campos_constraints_func_ = bb;
}

/* \brief Indicates wether to generate organized or unorganized data
/* \brief Indicates whether to generate organized or unorganized data
* \param b organized/unorganized
*/
void
Expand All @@ -88,7 +88,7 @@ namespace pcl
resolution_ = res;
}

/* \brief Wether to use the vertices or triangle centers of the tesselated sphere
/* \brief Whether to use the vertices or triangle centers of the tessellated sphere
* \param use true indicates to use vertices, false triangle centers
*/

Expand All @@ -107,7 +107,7 @@ namespace pcl
radius_sphere_ = radius;
}

/* \brief Wether to compute the entropies (level of occlusions for each view)
/* \brief Whether to compute the entropies (level of occlusions for each view)
* \param compute true to compute entropies, false otherwise
*/
void
Expand All @@ -116,8 +116,8 @@ namespace pcl
compute_entropy_ = compute;
}

/* \brief How many times the icosahedron should be tesselated. Results in more or less camera positions and generated views.
* \param level amount of tesselation
/* \brief How many times the icosahedron should be tessellated. Results in more or less camera positions and generated views.
* \param level amount of tessellation
*/
void
setTesselationLevel (int level)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ namespace pcl
virtual void next ();

Q_SIGNALS:
/** \brief Ommitted when a filter is created. */
/** \brief Omitted when a filter is created. */
void filterCreated ();

protected:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ class Cloud : public Statistics
/// The internal representation of the cloud
Cloud3D cloud_;

/// @breif A weak pointer pointing to the selection object.
/// @brief A weak pointer pointing to the selection object.
/// @details This implementation uses the weak pointer to allow for a lazy
/// update of the cloud if the selection object is destroyed.
boost::weak_ptr<Selection> selection_wk_ptr_;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
class CommandQueue
{
public:
/// @brief Defaut Constructor
/// @brief Default Constructor
/// @details Creates a command queue object and makes its depth limit
/// be the default value.
CommandQueue ();
Expand Down Expand Up @@ -81,7 +81,7 @@ class CommandQueue
void
undo ();

/// @breif Changes the command history limit.
/// @brief Changes the command history limit.
/// @details If the passed size is smaller than the current size then the
/// oldest commands are removed (their undo functions are not called).
/// @param size The new maximum number of commands that may exist in this
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
///

/// @file transformCommand.h
/// @details a TransfromCommand object provides transformation and undo
/// @details a TransformCommand object provides transformation and undo
/// functionalities. // XXX - transformation of what?
/// @author Yue Li and Matthew Hielsberg

Expand Down
2 changes: 1 addition & 1 deletion apps/point_cloud_editor/src/common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ multMatrix(const float* left, const float* right, float* result)

// This code was found on:
// http://stackoverflow.com/questions/1148309/inverting-a-4x4-matrix
// and is listed as being part of an open soure project (the MESA project)
// and is listed as being part of an open source project (the MESA project)
//
// The original code in MESA comes from __gluInvertMatrixd() in project.c
//
Expand Down
Loading