Fix typos in the whole codebase #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
There's a merge conflict here. Rebase to the current master to fix it please. $ git rebase origin/master
# you're gonna git complaining about conflicts
$ git mergetool
# after you fix the merge conflicts
$ git rebase --continue |
Found via `codespell -q 3 -I ../pcl-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty"` Whitelist: ``` ang childs everytime iff indeces isnt ith lod metre metres mitre nd normaly ot resizeable te vertexes ```
luzpaz
force-pushed
the
misc-typos-revised
branch
from
3d35a93 to
b9916c3
Compare
|
done. |
luzpaz
commented
Feb 20, 2018
simulation/src/range_likelihood.cpp
Outdated
| @@ -539,7 +539,7 @@ costFunction4(float ref_val,float depth_val) | |||
| float proportion = 0.999f; | |||
| float lhood = proportion + (1-proportion)*(top/bottom); | |||
|
|
|||
| // safety fix thats seems to be required due to opengl ayschronizate | |||
| // safety fix that seems to be required due to opengl asyschronizate | |||
There was a problem hiding this comment.
please check these fixes
There was a problem hiding this comment.
Darn, i left a typo in asyschronizate. But actually after more research (not sure I why I didn't do this the first time) I think the word should actually be asynchronization
There was a problem hiding this comment.
Can someone respond to this?
There was a problem hiding this comment.
I'm no native speaker, but Wiktionary has such a word.
There was a problem hiding this comment.
Do you want to change this? Then we can merge.
There was a problem hiding this comment.
More importantly, who is Hordur? 😆 My guess would also go with asynchronization.
luzpaz
commented
Feb 20, 2018
| @@ -277,7 +277,7 @@ pcl::Morphology<PointT>::subtractionBinary ( | |||
| const pcl::PointCloud<PointT> &input1, | |||
| const pcl::PointCloud<PointT> &input2) | |||
| { | |||
| const int height = (input1.height < input2.hieght) ? input1.height : input2.height; | |||
| const int height = (input1.height < input2.height) ? input1.height : input2.height; | |||
luzpaz
commented
Feb 20, 2018
| @@ -299,7 +299,7 @@ pcl::Morphology<PointT>::unionBinary ( | |||
| const pcl::PointCloud<PointT> &input1, | |||
| const pcl::PointCloud<PointT> &input2) | |||
| { | |||
| const int height = (input1.height < input2.hieght) ? input1.height : input2.height; | |||
| const int height = (input1.height < input2.height) ? input1.height : input2.height; | |||
taketwo
approved these changes
Feb 20, 2018
|
Can we add a commit fixing #2228 ? |
Closed
SergioRAgostinho
added
needs: more work
luzpaz
force-pushed
the
misc-typos-revised
branch
from
d23c294 to
c056003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -I ../pcl-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty"Maintainer edit: fixes #2228