Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constexpr in KinFu and KinFu large scale apps #3386

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

SunBlack
Copy link
Contributor

During replacing min by std::min I got following compile error:

/media/sf_pcl/gpu/kinfu/src/cuda/tsdf_volume.cu(167): error: no instance of overloaded function "std::min" matches the argument list
            argument types are: (int, enum pcl::device::Tsdf::<unnamed>)

As marco defines are not recommend anymore, since constexpr exists, I decided to modernize this code a bit, so std::min(...) should work without using std::min<int>(...)

@SunBlack SunBlack force-pushed the constexpr_kinfu branch 2 times, most recently from 01043db to 06922a8 Compare September 27, 2019 20:50
@taketwo taketwo merged commit e76bccd into PointCloudLibrary:master Oct 1, 2019
@SunBlack SunBlack deleted the constexpr_kinfu branch October 1, 2019 14:07
@taketwo taketwo changed the title Use partially constexpr in kinfu & kinfu_large_scale Use constexpr in KinFu and KinFu large scale apps Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants