Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ccache on Ubuntu CI job #3415

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

kunaltyagi
Copy link
Member

Iterating on the Max Compiler Cache size

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like it solved the problem. Do you need to revert back to the original key before merging?

@kunaltyagi
Copy link
Member Author

Seem like it solved the problem

No. It didn't solve the problem. It reduced memory usage but with large compile times. I've gutted out the ccache 😢 for now.

revert back to the original key before merging

I'd have needed to. But no need now

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we merge this as is to get our CI back to a green state. Integrating/tweaking ccache inside the ubuntu job can come later.

@kunaltyagi kunaltyagi merged commit 72a0c4f into PointCloudLibrary:master Oct 22, 2019
@kunaltyagi kunaltyagi deleted the test-ci branch October 22, 2019 12:34
@kunaltyagi
Copy link
Member Author

kunaltyagi commented Oct 22, 2019

The issue with tweaking is that the cache issues are hard to find out with CI. Local experiments don't match CI and dummy CI setup (like the commit which added ccache for CI) don't really imply a stable behavior in future. I'd drop this for now for CI

@SergioRAgostinho
Copy link
Member

👍 No opposition from my side.

@taketwo
Copy link
Member

taketwo commented Oct 29, 2019

It's a pity, but indeed green CI is better than fast CI.

@taketwo taketwo changed the title Testing with smaller cache size Disable ccache on Ubuntu CI job Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants