Homogenize deprecations with PCL_DEPRECATED

[aPonza]

Stems from #3905. I git grep -n deprec and tried my best at recognizing the results needing homogeneity.

The missing instances are tracked in #3924

Fixes #2724

[kunaltyagi]

LGTM (except inline)

[aPonza]

Nice! The tutorials build caught a deprecation warning in the examples:

/__w/1/s/doc/tutorials/content/sources/registration_api/example2.cpp: In function 'void rejectBadCorrespondences(const CorrespondencesPtr&, const Ptr&, const Ptr&, pcl::Correspondences&)':
/__w/1/s/doc/tutorials/content/sources/registration_api/example2.cpp:123:45: error: 'void pcl::registration::CorrespondenceRejectorDistance::setInputCloud(const typename pcl::PointCloud<PointT>::ConstPtr&) [with PointT = pcl::PointXYZ; typename pcl::PointCloud<PointT>::ConstPtr = boost::shared_ptr<const pcl::PointCloud<pcl::PointXYZ> >]' is deprecated: pcl::registration::CorrespondenceRejectorDistance::setInputCloud is deprecated. Please use setInputSource instead (It will be removed in PCL 1.12) [-Werror=deprecated-declarations]
   rej.setInputCloud<PointXYZ> (keypoints_src);
                                             ^
In file included from /__w/1/s/doc/tutorials/content/sources/registration_api/example2.cpp:12:0:
/__w/1/install/include/pcl-1.10/pcl/registration/correspondence_rejection_distance.h:109:9: note: declared here
         setInputCloud (const typename pcl::PointCloud<PointT>::ConstPtr &cloud)
         ^
cc1plus: all warnings being treated as errors

No clue about what windows wants from me though:

     Creating library D:/a/build/lib/pcl_surface.lib and object D:/a/build/lib/pcl_surface.exp
  Generating code
  LINK : the 32-bit linker (C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\link.exe) ran out of heap space and is going to restart linking with a 64-bit linker
  LINK : restarting link with 64-bit linker `C:\Program Files\Git\usr\bin\link.exe'
  /c/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/HostX86/x64/link: cannot create link ' ■/' to '/ERRORREPORT:QUEUE': No such file or directory
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(720,5): error MSB6006: "link.exe" exited with code 1. [D:\a\build\surface\pcl_surface.vcxproj]
  Building Custom Rule D:/a/1/s/tracking/CMakeLists.txt
  tracking.cpp
  particle_filter.cpp
  kld_adaptive_particle_filter.cpp
  coherence.cpp

The linker is complaining (link), I'm not touching [surface] directly... Is it some inspectable problem? SO gives answers that are all over the place. this was about link.exe, not cmd.exe
EDIT this might be the link I was after, and it's solved in VS2019. Let's first see if it happens again.

[kunaltyagi]

ran out of heap space

Windows OOMed. Restarting can sometimes solve the issue.

[kunaltyagi]

CI is green. 🚀

[SergioRAgostinho]

LGTM but we need to figure out what to do with the deprecations with empty messages.

[SergioRAgostinho]

Minor indentation issue in my patch. Leave it for clang-format.

[kunaltyagi]

LGTM. The based on the online comment, the labels need to be updated

[aPonza]

Commit wise I'm thinking:

• homogenize;
• fix setInputSource;
• fix deallocemptynodecache.

[kunaltyagi]

Rebase + CI = 🚀

more work needed

[kunaltyagi]

Squash DeAllocEmptyNodeCache related commits or squash all during merge?