Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: tool to find grid minimums #603

Merged
merged 1 commit into from
Apr 4, 2014
Merged

Add: tool to find grid minimums #603

merged 1 commit into from
Apr 4, 2014

Conversation

chambbj
Copy link
Contributor

@chambbj chambbj commented Apr 1, 2014

No description provided.

@taketwo
Copy link
Member

taketwo commented Apr 2, 2014

GridMinimum supports a number of parameters, however this tool only allows to set resolution. Wouldn't it make sense to add the others?

@chambbj
Copy link
Contributor Author

chambbj commented Apr 2, 2014

I may want to go the other way actually...to reduce the number of params in GridMinimum. It's another case of me borrowing heavily from an existing filter (VoxelGrid in this case). Resolution or leaf size is the only one that I envision using.

@taketwo
Copy link
Member

taketwo commented Apr 2, 2014

This includes enforcing rectangular cells?

@chambbj chambbj mentioned this pull request Apr 3, 2014
Merged
@taketwo
Copy link
Member

taketwo commented Apr 4, 2014

I guess this needs to be updated to accommodate for the changes introduced in #608.

@chambbj
Copy link
Contributor Author

chambbj commented Apr 4, 2014

@taketwo Just pushed the update.

taketwo added a commit that referenced this pull request Apr 4, 2014
@taketwo
Merge pull request #603 from chambbj/add-grid-min-tool
6e61d01 
Add: tool to find grid minimums
@taketwo taketwo merged commit 6e61d01 into PointCloudLibrary:master Apr 4, 2014
@chambbj chambbj deleted the add-grid-min-tool branch April 4, 2014 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chambbj @taketwo