simplify the GridMinimum interface #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,13 +73,8 @@ | |||
| public: | |||
| /** \brief Empty constructor. */ | |||
| GridMinimum () : | |||
There was a problem hiding this comment.
Given that the class has a single configuration parameter wouldn't it make sense to be able to set it via constructor?
|
@taketwo That's fine. I now allow setting resolution via constructor or |
| div_b_ (Eigen::Vector4i::Zero ()), | ||
| divb_mul_ (Eigen::Vector4i::Zero ()), | ||
| min_points_per_grid_ (0) | ||
| GridMinimum (const float &resolution) |
There was a problem hiding this comment.
It's recommended to pass primitive types by value (see e.g. this)
|
@taketwo Fixed. |
| */ | ||
| inline void | ||
| setLeafSize (const Eigen::Vector4f &leaf_size) | ||
| setResolution (const float &resolution) |
|
@taketwo Once again... |
taketwo
added a commit
that referenced
this pull request
Apr 4, 2014
simplify the GridMinimum interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per related discussion in #603