Pcd recorder improvements #673
Conversation
| " -shift = use OpenNI shift values rather than 12-bit depth\n" | ||
| " -buf X = use a buffer size of X frames (default: "); | ||
| print_value ("%d", buff_size); print_info (")\n"); | ||
| printHelp(buff_size, argc, argv); |
There was a problem hiding this comment.
Sorry for being picky, but could you adopt this to the pcl style guide (http://pointclouds.org/documentation/advanced/pcl_style_guide.php), i.e., add a space in front of the bracket? Thanks!
There was a problem hiding this comment.
Oh, sorry about that. That whole block was actually redundant and should have been removed (there is another help switch check in the block below, taken from the openni_viewer).
Updated the pull request.
|
There are still a couple of whitespace errors in there, would be great if you could fix them. Thanks for your time! |
|
Here you go. I added the same whitespace fixes to openni_viewer as well. |
|
Thanks for responding so fast. Regarding the last commit, I prefer to not fix the style of code in the repo, as it would change the author of the line. Could you squash your other commits a little, so we don't pull in unnecessary changes? Have a look at git rebase -i. |
|
Finally found the time to do it. How's this? |
|
The Travis CI build for gcc got to 99%, then ran out of time. The clang build succeeded. |
The recorder now has command-line support for device IDs just like openni_viewer.
This is a new pull request based on #672 without the changes to memory size calculation.