Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove manifest from build.rs and leave it to users #76

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Jun 17, 2022

Reference: #75 tauri-apps/tauri#4374

In Tauri, use winres for embedding the manifest: tauri-apps/tauri#4383

version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, no need for this autogenerated comment

Copy link
Owner

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@PolyMeilex PolyMeilex merged commit 1ce3cdb into PolyMeilex:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants