-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customize button texts of message dialog #4383
feat: customize button texts of message dialog #4383
Conversation
e95d2ce
to
5b43bfa
Compare
Nice PR! |
While there is a new problem: the dialog level (Info / Warning / Error) is not implemented in the new message dialog. |
I'm not familiar with Tauri architecture yet but beware that your manifest may need external edits, may get overwritten, etc. for users that need to add identity, enable high-DPI, add registration-free coclass entries, etc. |
I think that all manifests should be added by tauri, and provide some config option to users if necessary. Just like what electron does: electron/electron#14596 |
5b43bfa
to
878163d
Compare
878163d
to
88d5a11
Compare
Test failed:
Seems because common controls v6 was not used when testing. I am unfamiliar with the |
@meowtec it's not related to the restart crate; even if you remove both |
Fixed with a trick @meowtec :P |
Is ask('something?', { okLabel: 'Sure', cancelLabel: 'Definitely not' }) |
Implements #3455 |
and #2147 |
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Demo:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Now we can show message dialog with customize buttons.
Limit: we can have at most two buttons. If need more buttons, the dialog API should have breaking change. I have no idea about the best solution.