Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and simplify examples #10743

Merged
merged 13 commits into from
Aug 26, 2024
Merged

chore: cleanup and simplify examples #10743

merged 13 commits into from
Aug 26, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Aug 22, 2024

  • Updated .gitignore file
  • Simplified and cleanedup examples
  • Removed examples that serve almost zero value:
    • navigation
    • parent-window
    • web
    • workspace
    • plugins/tauri-plugin-sample: the plugin example in api example is enough

- Updated `.gitignore` file
- Simplified and cleanedup examples
- Removed examples that serve almost zero value:
  - `navigation`
  - `parent-window`
  - `web`
  - `workspace`
  - `run-iteration`
  - `plugins/tauri-plugin-sample`: the plugin example in `api` example is enough
@amrbashir amrbashir requested a review from a team as a code owner August 22, 2024 18:43
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Package Changes Through f316e40

There are 7 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-codegen with prerelease, tauri with prerelease, tauri-bundler with prerelease, tauri-utils with prerelease, tauri-build with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.6 2.0.0-rc.7
tauri-bundler 2.0.1-rc.5 2.0.1-rc.6
tauri-runtime 2.0.0-rc.6 2.0.0-rc.7
tauri-runtime-wry 2.0.0-rc.6 2.0.0-rc.7
tauri-codegen 2.0.0-rc.6 2.0.0-rc.7
tauri-macros 2.0.0-rc.5 2.0.0-rc.6
tauri-plugin 2.0.0-rc.6 2.0.0-rc.7
tauri-build 2.0.0-rc.6 2.0.0-rc.7
tauri 2.0.0-rc.6 2.0.0-rc.7
@tauri-apps/cli 2.0.0-rc.7 2.0.0-rc.8
tauri-cli 2.0.0-rc.7 2.0.0-rc.8

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link

socket-security bot commented Aug 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/vite@5.4.2 Transitive: environment, filesystem, network, shell +4 3.75 MB antfu, patak, soda, ...2 more

🚮 Removed packages: npm/@esbuild/android-arm@0.15.13), npm/@esbuild/linux-loong64@0.15.13), npm/@iarna/toml@2.2.5), npm/@jridgewell/resolve-uri@3.1.0), npm/@jridgewell/sourcemap-codec@1.4.14), npm/@jridgewell/trace-mapping@0.3.17), npm/@mapbox/node-pre-gyp@1.0.10), npm/@polka/url@1.0.0-next.21), npm/@sveltejs/adapter-auto@1.0.0-next.86), npm/@sveltejs/adapter-cloudflare@1.0.0-next.40), npm/@sveltejs/adapter-netlify@1.0.0-next.83), npm/@sveltejs/adapter-static@1.0.0-next.47), npm/@sveltejs/adapter-vercel@1.0.0-next.81), npm/@sveltejs/kit@1.0.0-next.532), npm/@sveltejs/vite-plugin-svelte@1.1.0), npm/@swc/core-darwin-arm64@1.3.14), npm/@swc/core-darwin-x64@1.3.14), npm/@swc/core-linux-arm-gnueabihf@1.3.14), npm/@swc/core-linux-arm64-gnu@1.3.14), npm/@swc/core-linux-arm64-musl@1.3.14), npm/@swc/core-linux-x64-gnu@1.3.14), npm/@swc/core-linux-x64-musl@1.3.14), npm/@swc/core-win32-arm64-msvc@1.3.14), npm/@swc/core-win32-ia32-msvc@1.3.14), npm/@swc/core-win32-x64-msvc@1.3.14), npm/@swc/core@1.3.14), npm/@tauri-apps/api@1.1.0), npm/@types/cookie@0.5.1), npm/@types/node@18.11.9), npm/@types/pug@2.0.6), npm/@types/sass@1.43.1), npm/@vercel/nft@0.22.1), npm/abbrev@1.1.1), npm/acorn@8.8.1), npm/agent-base@6.0.2), npm/anymatch@3.1.2), npm/aproba@2.0.0), npm/are-we-there-yet@2.0.0), npm/async-sema@3.1.1), npm/binary-extensions@2.2.0), npm/bindings@1.5.0), npm/braces@3.0.2), npm/buffer-crc32@0.2.13), npm/busboy@1.6.0), npm/chokidar@3.5.3), npm/chownr@2.0.0), npm/color-support@1.1.3), npm/console-control-strings@1.1.0), npm/cookie@0.5.0), npm/debug@4.3.4), npm/deepmerge@4.2.2), npm/delegates@1.0.0), npm/detect-indent@6.1.0), npm/detect-libc@2.0.1), npm/devalue@4.2.0), npm/es6-promise@3.3.1), npm/esbuild-android-64@0.15.13), npm/esbuild-android-arm64@0.15.13), npm/esbuild-darwin-64@0.15.13), npm/esbuild-darwin-arm64@0.15.13), npm/esbuild-freebsd-64@0.15.13), npm/esbuild-freebsd-arm64@0.15.13), npm/esbuild-linux-32@0.15.13), npm/esbuild-linux-64@0.15.13), npm/esbuild-linux-arm64@0.15.13), npm/esbuild-linux-arm@0.15.13), npm/esbuild-linux-mips64le@0.15.13), npm/esbuild-linux-ppc64le@0.15.13), npm/esbuild-linux-riscv64@0.15.13), npm/esbuild-linux-s390x@0.15.13), npm/esbuild-netbsd-64@0.15.13), npm/esbuild-openbsd-64@0.15.13), npm/esbuild-sunos-64@0.15.13), npm/esbuild-windows-32@0.15.13), npm/esbuild-windows-64@0.15.13), npm/esbuild-windows-arm64@0.15.13), npm/esbuild@0.15.13), npm/fast-glob@3.2.12), npm/fastq@1.13.0), npm/file-uri-to-path@1.0.0), npm/fill-range@7.0.1), npm/fs-extra@10.1.0), npm/fs-minipass@2.1.0), npm/fsevents@2.3.2), npm/function-bind@1.1.1), npm/gauge@3.0.2), npm/globalyzer@0.1.0), npm/globrex@0.1.2), npm/graceful-fs@4.2.10), npm/has-unicode@2.0.1), npm/has@1.0.3), npm/https-proxy-agent@5.0.1), npm/is-core-module@2.11.0), npm/lru-cache@6.0.0), npm/make-dir@3.1.0), npm/micromatch@4.0.5), npm/mime@3.0.0), npm/min-indent@1.0.1), npm/minimist@1.2.7), npm/minipass@3.3.4), npm/minizlib@2.1.2), npm/mkdirp@1.0.4), npm/mri@1.2.0), npm/mrmime@1.0.1), npm/nanoid@3.3.4), npm/node-fetch@2.6.7), npm/node-gyp-build@4.5.0), npm/nopt@5.0.0), npm/npmlog@5.0.1), npm/object-assign@4.1.1), npm/picocolors@1.0.0), npm/postcss@8.4.18), npm/readable-stream@3.6.0), npm/regexparam@2.0.1), npm/resolve@1.22.1), npm/rimraf@3.0.2), npm/rollup-pluginutils@2.8.2), npm/sade@1.8.1), npm/sander@0.5.1), npm/semver@6.3.0), npm/set-blocking@2.0.0), npm/set-cookie-parser@2.5.1), npm/sirv@2.0.2), npm/sorcery@0.10.0), npm/source-map-js@1.0.2), npm/streamsearch@1.1.0), npm/string_decoder@1.3.0), npm/strip-indent@3.0.0), npm/svelte-check@2.9.2), npm/svelte-hmr@0.15.0), npm/svelte-preprocess@4.10.7), npm/svelte@3.52.0), npm/tar@6.1.12), npm/tiny-glob@0.2.9), npm/totalist@3.0.0), npm/tr46@0.0.3), npm/tslib@2.4.1), npm/typescript@4.8.4), npm/undici@5.12.0), npm/universalify@2.0.0), npm/util-deprecate@1.0.2), npm/vite-plugin-static-copy@0.11.1), npm/vite-plugin-top-level-await@1.2.1), npm/vite-plugin-wasm@3.1.0), npm/vite@3.2.2), npm/vite@5.4.0), npm/wasm@0.1.0), npm/webidl-conversions@3.0.1), npm/whatwg-url@5.0.0), npm/wide-align@1.1.5), npm/worktop@0.8.0-next.14), npm/yallist@4.0.0)

View full report↗︎

@amrbashir
Copy link
Member Author

so linking the api example manifest using tauri-winres results in STATUS_ENTRYPOINT_NOT_FOUND but if directly embedding it using cargo:rustc-link-arg=/MANIFEST:EMBED has no issues. I hate windows

@lucasfernog
Copy link
Member

so linking the api example manifest using tauri-winres results in STATUS_ENTRYPOINT_NOT_FOUND but if directly embedding it using cargo:rustc-link-arg=/MANIFEST:EMBED has no issues. I hate windows

I guess the __TAURI_WORKSPACE__ workaround doesn't help us here right? since it's a binary that must have that one

@amrbashir
Copy link
Member Author

The __TAURI_WORKSPACE__ workaround also uses cargo:rustc-link-arg=/MANIFEST:EMBED and that's what works

@amrbashir
Copy link
Member Author

I will spend sometime to test and see what's the different and why this happens.

@amrbashir amrbashir merged commit ad83d41 into dev Aug 26, 2024
34 checks passed
@amrbashir amrbashir deleted the chore/cleanup-examples branch August 26, 2024 22:25
@honnip honnip mentioned this pull request Sep 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants