Add correct ng annotate loader #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ const HtmlPlugin = require('html-webpack-plugin') | |||
| const NgAnnotatePlugin = require('ng-annotate-webpack-plugin') | |||
| const OmitTildeWebpackPlugin = require('omit-tilde-webpack-plugin') | |||
| const webpack = require('webpack') | |||
| const combineLoaders = require('webpack-combine-loaders') | |||
There was a problem hiding this comment.
mais oui je comprends l'intéret. je n'ai rien dit.
|
LGTM so far |
ramabouda
force-pushed
the
rboucher/ng-annotate
branch
2 times, most recently
from
1738357
to
96ac674
Compare
|
|
||
| The angular profile add the ng-annotate loader. | ||
| FIXME(rboucher) | ||
| `ng-annotate` **does not support arrow functions** for now. |
There was a problem hiding this comment.
donne juste un exemple de cas où ça ne fonctionne pas.
added 7 commits
April 15, 2016 15:14
ramabouda
force-pushed
the
rboucher/ng-annotate
branch
from
96ac674
to
3f12416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Todo : make private ng-annotate package until this PR gets merged