Add es6 option #241
Closed
Add es6 option #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables sourceType mode "module" for acorn
|
Any feedback on this? |
|
It would be nice to have this PR merged. I can confirm that it allows to use ng-annotate with es2015 syntax (see https://github.com/anlambert/webpack-gulp-es6-angular-express for a sample project). Currently, I am forced to use npm-shrinkwrap to fetch ng-annotate from @Raphael-Boucher repository. |
|
@olov Can this be merged? |
|
#240 is also needed for complete es6 support. |
|
Hi all, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables sourceType mode "module" for acorn, to manage
import.It should solve #227, #237 and andrey-skl/ng-annotate-loader#17.
A few changes to the scope tools where needed to support es6 language additions.