Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add note about escaping in shells #1481

Merged
merged 1 commit into from Jan 7, 2016
Merged

Add note about escaping in shells #1481

merged 1 commit into from Jan 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2016

When I ran the install command in zsh, it reported zsh: no matches found: Polymer/polymer#^1.2.0. So I added a small note.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link
Author

ghost commented Jan 1, 2016

Signed!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 1, 2016
@robdodson
Copy link
Contributor

Actually I'm wondering why we're encoding a specific version number here? Wouldn't bower install --save polymer/polymer be a better approach?

@ghost
Copy link
Author

ghost commented Jan 3, 2016

It wouldn't, because that would grab 1.2.3, which I believe is a dev version (not sure though!)

@robdodson
Copy link
Contributor

1.2.3 is just the latest release (we don't do dev versions). When you run bower install --save it writes whatever the latest tag is to your bower.json. The advantage is you'll always get the latest and greatest (which is important if we do a major version revision but forget to go back and update the article). Ultimately it's probably not a huge deal, but just something I noticed. If at some point we're on Polymer v1.5.7 it's going to feel weird to tell folks to peg their install to 1.2.3

@arthurevans
Copy link

It used to just say #^1.0, to pin it to "latest version >= 1.0, < 2.0," which seemed appropriate.
But people keep updating it while I'm not looking :D

@robdodson
Copy link
Contributor

If you do bower install --save polymer/polymer it'll give you ~.1.2.3 which will protect from a major version rev. I think we should shorten it to that command

@arthurevans
Copy link

That makes sense. I guess the #^version is a holdover from the 0.5 days. I'll merge this and massage the text a bit.

arthurevans pushed a commit that referenced this pull request Jan 7, 2016
Add note about escaping in shells
@arthurevans arthurevans merged commit 10bf35f into Polymer:master Jan 7, 2016
@arthurevans
Copy link

Just realized that if we don't include the #^1.2.0, we don't need the note. Sorry. A little slow today.

@arthurevans
Copy link

New PR here: #1488

@ghost ghost deleted the patch-1 branch January 8, 2016 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants