-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Simplify install command, add note on versioning. #1488
Conversation
@robdodson @ebidel PTAL. |
{ | ||
"name": "my-project", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"polymer": "Polymer/polymer#^1.2.0" | ||
"polymer": "Polymer/polymer#~<var>currentVersion</var>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this do magical stuff and insert the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just an HTML <var>
tag, indicating replacement text. The paragraph below explains it. Rather than using template magic, I was just going to do this, to explain that the version will vary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you simplify it to:
"polymer": "Polymer/polymer#~1.X.X"
maybe?
LGTM if those variable tags do what they seem to do :D |
OK, changed to 1.X.X and updated the comment. Better? |
Does it still need the var tags and explanation? I think it's implied that 1.x.x means a version range. |
Should we stick with ^ instead so people get minor updates. On Sun, Jan 10, 2016, 12:51 PM Rob Dodson notifications@github.com wrote:
|
@ebidel when you run |
Maybe it's more of an issue with element updates, but I've seen folks not get the minor bumps from dependencies. |
Ah I'm wrong :P
|
Hm gross check this out: bower/bower#2121
|
Opened a bower issues to try to discuss this... bower/bower#2144 |
PR to change the behavior is here: bower/bower#2145 |
So, should we change the install advice here? My objection to the Maybe we should change this back to |
I think the advice as written is fine. I may even swap out the tilde for caret since that'll be in the next release of bower anyway. |
Updated now that the new bower is live, and added a note for folks using the older version. WTYT @robdodson @ebidel ? |
No comments here, merging based on earlier convo. |
Simplify install command, add note on versioning.
No description provided.