Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macosx11.1 support to configure #469

Closed
wants to merge 1 commit into from
Closed

Conversation

philburk
Copy link
Collaborator

This is needed to support the new XCode 12.3.
I also went ahead and added macosx11.2 because it is surely coming.

Also changed macosx-version-min to 10.6

Fixes #378
Fixes #468

This is needed to support the new XCode 12.3.
I also went ahead and added macosx11.2 because it is surely coming.

Also changed macosx-version-min to 10.6

Fixes #378
Fixes #468
@Be-ing
Copy link
Collaborator

Be-ing commented Jan 24, 2021

Why is there an upper limit on the supported SDK version?

@philburk
Copy link
Collaborator Author

Why is there an upper limit on the supported SDK version?

@Be-ing - What limit are you referring to? Are you asking why I stopped at "11.2"?

My answer would be that the elif chain is cumbersome. In the past we only supported released SDKs. I added 11.2 in anticipation of the next release. How many is enough? I don't know.

I also added a TODO that suggested using -showsdks to avoid the chain of elifs and also work automatically with some future releases. But that requires a bit more study. This was a quick fix for a broken build.

@Be-ing
Copy link
Collaborator

Be-ing commented Jan 24, 2021

You can use xcodebuild -version -sdk macosx SDKVersion to get the installed version. Just check that is >= 10.6 and this PortAudio release will remain buildable on future versions of macOS.

@philburk
Copy link
Collaborator Author

Thanks! I need an emoji for head exploding.
I will experiment with that for an alternative PR.
I may go ahead and just merge this as an emergency fix.

@Be-ing
Copy link
Collaborator

Be-ing commented Jan 24, 2021

@philburk
Copy link
Collaborator Author

I am closing this in favor of #470. It is much simpler and will last longer without needing changes.
By the time it gets to the new code it should be SDK 1.6 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac: runtime crashes on Big Sur if built using SDK 11 Change MacOS build mmacosx-version-min to 10.5
2 participants