-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mac autoconf: support current and future SDKs #470
Conversation
I assume you've tested this locally on macOS 11? It doesn't seem that you're running any macOS CI?? |
Yes, I tested locally on Big Sur with XCode 12.3. We should add some Mac CI. |
I already added macOS CI in #459. |
This change looks good to me. Is there anything else that needs to be taken care of before releasing? |
Hi @philburk |
Thanks jmelas. I switched to xcrun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't easily test these changes right now, but if you have multiple people saying that the changes work, then I see no reason to hold off on merging.
Improve the way we generate the path to the SDK so that it it not tied to specific Mac versions. Also changed macosx-version-min to 10.6 Fixes PortAudio#378 Fixes PortAudio#468 Use xcrun instead of xcodebuild Note that "configure" was generated using autoconf on Linux.
Improve the way we generate the path to the SDK so that it
it not tied to specific versions.
Also changed macosx-version-min to 10.6
Fixes #378
Fixes #468