Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac autoconf: support current and future SDKs #470

Merged
merged 3 commits into from
Jan 26, 2021
Merged

mac autoconf: support current and future SDKs #470

merged 3 commits into from
Jan 26, 2021

Conversation

philburk
Copy link
Collaborator

Improve the way we generate the path to the SDK so that it
it not tied to specific versions.

Also changed macosx-version-min to 10.6

Fixes #378
Fixes #468

Improve the way we generate the path to the SDK so that it
it not tied to specific versions.

Also changed macosx-version-min to 10.6

Fixes #378
Fixes #468
@Be-ing
Copy link
Collaborator

Be-ing commented Jan 25, 2021

I assume you've tested this locally on macOS 11? It doesn't seem that you're running any macOS CI??

@philburk
Copy link
Collaborator Author

philburk commented Jan 25, 2021

Yes, I tested locally on Big Sur with XCode 12.3. We should add some Mac CI.

@Be-ing
Copy link
Collaborator

Be-ing commented Jan 25, 2021

I already added macOS CI in #459.

@Be-ing
Copy link
Collaborator

Be-ing commented Jan 25, 2021

This change looks good to me. Is there anything else that needs to be taken care of before releasing?

configure Show resolved Hide resolved
configure.in Show resolved Hide resolved
@philburk
Copy link
Collaborator Author

@jmelas - I see that in #359 you suggested:

mac_sysroot="-isysroot $(xcrun --sdk macosx --show-sdk-path)"

How does that compare to using xcodebuild like I did in this script?

@philburk philburk added this to the V19.7 milestone Jan 25, 2021
@jmelas
Copy link
Contributor

jmelas commented Jan 25, 2021

@jmelas - I see that in #359 you suggested:

mac_sysroot="-isysroot $(xcrun --sdk macosx --show-sdk-path)"

How does that compare to using xcodebuild like I did in this script?

Hi @philburk
In my machine the command
xcrun --sdk macosx --show-sdk-path
executes much faster than
xcodebuild -version -sdk macosx Path

@philburk
Copy link
Collaborator Author

Thanks jmelas. I switched to xcrun.

Copy link
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't easily test these changes right now, but if you have multiple people saying that the changes work, then I see no reason to hold off on merging.

configure Outdated Show resolved Hide resolved
@RossBencina RossBencina assigned philburk and unassigned RossBencina Jan 26, 2021
@philburk philburk merged commit fa525d6 into master Jan 26, 2021
@philburk philburk deleted the fix_468_sdk branch January 26, 2021 23:25
illuusio pushed a commit to illuusio/portaudio that referenced this pull request Oct 21, 2021
Improve the way we generate the path to the SDK so that it
it not tied to specific Mac versions.

Also changed macosx-version-min to 10.6

Fixes PortAudio#378
Fixes PortAudio#468

Use xcrun instead of xcodebuild

Note that "configure" was generated using autoconf on Linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac: runtime crashes on Big Sur if built using SDK 11 Change MacOS build mmacosx-version-min to 10.5
4 participants