Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External clickhouse support #276

Merged
merged 30 commits into from
Jan 31, 2022
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d3695cf
Remove dead vars `clickhouse.replication`, `clickhouse.async` from cl…
macobo Jan 26, 2022
8060255
Refactor: move clickhouse env variables to a snippet
macobo Jan 26, 2022
6edb9c4
Move from a snippet+helpers file to a single "helpers" file
macobo Jan 26, 2022
7e5493c
Allow specifying clickhouse cluster name
macobo Jan 26, 2022
e8ba966
Remove CLICKHOUSE_HOST customization
macobo Jan 26, 2022
019728f
Allow passing external clickhouse configuration to the chart
macobo Jan 26, 2022
773901e
Allow specifying external secrets, add unit tests
macobo Jan 26, 2022
3e342db
Fix password/redis copy-pasta errors
macobo Jan 27, 2022
1778312
Support dict for vars, dynamic namespace in utils
macobo Jan 27, 2022
ce440d6
Add connectivity tests for clickhouse
macobo Jan 27, 2022
a7839b2
Fix formatting
macobo Jan 27, 2022
14586cf
Fix waiting for migrations env settings
macobo Jan 27, 2022
9f51310
Solve unittest related issues
macobo Jan 27, 2022
312f6de
Small fix to events deployment
macobo Jan 27, 2022
e9355a6
Deal with errant ClusterRole left behind
macobo Jan 27, 2022
428c565
Make internal clickhouse user configurable
macobo Jan 27, 2022
a04560f
Make externalClickhouse.cluster required
macobo Jan 27, 2022
2a1b503
Fixup a comment
macobo Jan 27, 2022
0eb07c7
Fail if clickhouse.replication is set
macobo Jan 27, 2022
c437696
Debugging: emit a namespace report
macobo Jan 27, 2022
c48e73a
Experiment: delete namespace
macobo Jan 28, 2022
5670e33
Try delete chi instead
macobo Jan 28, 2022
aa61cde
ignore_errors
macobo Jan 28, 2022
4bf1efb
Delete CHI first
macobo Jan 29, 2022
a317f9c
Cleanup clusterrole
macobo Jan 29, 2022
434b35e
Merge yamls
macobo Jan 30, 2022
2b828ca
Debug: print commands
macobo Jan 30, 2022
96369b5
Iterate debug code
macobo Jan 30, 2022
efc0cef
Update values.yaml docs
macobo Jan 31, 2022
808d2cd
Remove a TODO
macobo Jan 31, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Experiment: delete namespace
macobo committed Jan 28, 2022
commit c48e73a163923f4778889e8568ab8506a76fa4f4
8 changes: 3 additions & 5 deletions ci/kubetest/utils.py
Original file line number Diff line number Diff line change
@@ -31,11 +31,9 @@
def cleanup_k8s(namespaces=["default", NAMESPACE]):
log.debug("🔄 Making sure the k8s cluster is empty...")
for namespace in namespaces:
cmd = "kubectl delete all --all -n {namespace}".format(namespace=namespace)
cmd_run = subprocess.run(cmd, shell=True)
cmd_return_code = cmd_run.returncode
if cmd_return_code:
pytest.fail("❌ Error while running '{}'. Return code: {}".format(cmd, cmd_return_code))
exec_subprocess(f"kubectl delete all --all -n {namespace}")
if namespace != 'default':
exec_subprocess(f"kubectl delete namespace {namespace} --ignore-not-found")
log.debug("✅ Done!")