External clickhouse support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
external-clickhouse2
branch
2 times, most recently
from
90a4ef6 to
857c7fb
Compare
macobo
force-pushed
the
external-clickhouse2
branch
from
ae23af3 to
c437696
Compare
This was referenced Jan 27, 2022
| @@ -0,0 +1,9 @@ | |||
| {{- if .Values.testTemplates -}} | |||
There was a problem hiding this comment.
Can you add a README.md in this folder with the explanation on why we need those templates? I think I've linked you recently the issue in helm unittest about it (but I can't find it anymore)
There was a problem hiding this comment.
I can't - it would break helm templating. :(
I could rename this to templates/_test_template.yaml though and add the comment there? We could add all the testing-specific templates to a file instead of a folder then.
There was a problem hiding this comment.
sounds good but feel free to merge this and then we can iterate further
macobo
commented
Jan 28, 2022
macobo
force-pushed
the
external-clickhouse2
branch
from
b175799 to
e4089af
Compare
macobo
force-pushed
the
external-clickhouse2
branch
from
e4089af to
c48e73a
Compare
macobo
force-pushed
the
external-clickhouse2
branch
from
1c6859a to
a317f9c
Compare
macobo
force-pushed
the
external-clickhouse2
branch
from
55b3e0d to
96369b5
Compare
This was referenced Jan 31, 2022
guidoiaquinti
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a breaking change, allowing users to connect to an external clickhouse. #190
This involved some bigger changes:
clickhouse.hostvalue has been removed and will error if used going forwardclickhouse.clusterhas been added - previouslyclickhouse.databasewas used to determine generated cluster nameclickhouse.replicationwas removed - this is currently unsupported by the app and will require significant work to support. Related: Make self-hosted clickhouse instances shardable posthog#8134clickhouse.enabledsemantics changed - previously it tried to spin up posthog without any clickhouse support which wouldn't really work.clickhouse.userwas previously not respected, instead anadminuser was always created.externalClickhousehas been added. If you want to use external clickhouse, setclickhouse.enabled: falseand setexternalClickhousevalues. host, cluster, user are always required and either password- or secrets-based auth is available. Note that a clickhouse cluster is required for posthog to runDocumentation PR: PostHog/posthog.com#2855
In practice though using external clickhouse never worked due to a myriad of issues (see PRs linking here)
Code structure notes:
_clickhouse.tplfile. Proposing we follow this pattern going forward as well._clickhouse.tplis unit-tested using a helper template incharts/posthog/templates/test-templates/clickhouse-env.yaml. Files in that folder are not tested.Related TODOs:
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist