Make service requirements less strict for clickhouse #8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into this trying to use external clickhouse provided by altinity cloud. Clickhouse generally takes backwards compatibility seriously so no need to up-cap the supported version range - we should just make sure everything works at the minimum version.
yakkomajuri
reviewed
Jan 27, 2022
yakkomajuri
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this trying to use external clickhouse provided by altinity
cloud.
Clickhouse generally takes backwards compatibility seriously so no need
to up-cap the supported version range - we should just make sure
everything works at the minimum version.
Related PR: PostHog/charts-clickhouse#276