Support altinity cloud when fetching server version #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SELECT version() currently returns `21.8.13.1.altinitystable` on our demo environment which blows up. This PR makes it so we strip out the version.
| @@ -410,6 +410,8 @@ def _get_server_version(self, as_tuple=True): | |||
| except ServerError as e: | |||
| logger.exception('Cannot determine server version (%s), assuming 1.1.0', e) | |||
| ver = '1.1.0' | |||
| # :TRICKY: Altinity cloud uses a non-numeric suffix for the version, which this removes. | |||
There was a problem hiding this comment.
LGTM
Non-blocking: I'm new to this repo but can we add a test case for this? Also, should we use something like https://packaging.pypa.io/en/latest/version.html instead?
There was a problem hiding this comment.
I'd love to add a test, but sadly adding that support seems like would require a lot of work right now. Going to punt on this.
guidoiaquinti
approved these changes
Jan 27, 2022
macobo
added a commit
to PostHog/posthog
that referenced
this pull request
Jan 27, 2022
Relevant PR: PostHog/infi.clickhouse_orm#7
macobo
added a commit
to PostHog/posthog
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECT version() currently returns
21.8.13.1.altinitystableon our demo environment which blows up.This PR makes it so we strip out the non-numeric suffic on the version.
Related charts PR: PostHog/charts-clickhouse#276