Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rotate session id when reset is called #168

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Aug 29, 2024

💡 Motivation and Context

found during the #167 testing
when reset is called, the session id was set to null, so the next events wouldn't contain a session id anymore, in this case, the correct behaviour would be just rotating the session id.
this would affect session recording as well.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team August 29, 2024 07:44
@marandaneto marandaneto marked this pull request as ready for review August 29, 2024 07:44
@marandaneto marandaneto merged commit 26038a4 into main Aug 29, 2024
5 checks passed
@marandaneto marandaneto deleted the fix/rotate-reset-session branch August 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants