fix: read accessibilityLabel from parent's view to avoid performance …

…hit on RN (#259) * fix: read accessibilityLabel from parent's view to avoid performance hit on RN * fix
PostHog · Nov 20, 2024 · 4c548af · 4c548af
1 parent b999bac
commit 4c548af
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Next
 
+- fix: read accessibilityLabel from parent's view to avoid performance hit on RN ([#259](https://github.com/PostHog/posthog-ios/pull/259))
+
 ## 3.15.5 - 2024-11-19
 
 - fix: properly mask SwiftUI Text (and text-based views) ([#257](https://github.com/PostHog/posthog-ios/pull/257))

diff --git a/PostHog/Replay/UIView+Util.swift b/PostHog/Replay/UIView+Util.swift
@@ -22,7 +22,9 @@
             if let identifier = accessibilityIdentifier {
                 isNoCapture = checkLabel(identifier)
             }
-            if let label = accessibilityLabel, !isNoCapture {
+            // read accessibilityLabel from the parent's view to skip the RCTRecursiveAccessibilityLabel on RN which is slow and may cause an endless loop
+            // see https://github.com/facebook/react-native/issues/33084
+            if let label = super.accessibilityLabel, !isNoCapture {
                 isNoCapture = checkLabel(label)
             }