Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read accessibilityLabel from parent's view to avoid performance hit on RN #259

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Nov 20, 2024

💡 Motivation and Context

we dont need the parent's accessibilityLabel/concatenated with all the children if any
avoid recursive and endless function

💚 How did you test it?

running on RN and native iOS app with UIKit
Fix is not breaking compatibility

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review November 20, 2024 08:28
@marandaneto marandaneto requested a review from a team November 20, 2024 08:28
@marandaneto marandaneto changed the title Merge branch 'main' into fix/rn-accessibilityLabel fix: read accessibilityLabel from parent's view to avoid performance hit on RN Nov 20, 2024
Copy link
Contributor

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ioannisj ioannisj merged commit 4c548af into main Nov 20, 2024
9 checks passed
@ioannisj ioannisj deleted the fix/rn-accessibilityLabel branch November 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants