fix: rotate session id when reset is called (#174)

PostHog · Aug 29, 2024 · 9c6bacf · 9c6bacf
1 parent 939a349
commit 9c6bacf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## Next
 
+- fix: rotate session id when reset is called ([#174](https://github.com/PostHog/posthog-ios/pull/174))
 - chore: expose session id ([#165](https://github.com/PostHog/posthog-ios/pull/165)), ([#170](https://github.com/PostHog/posthog-ios/pull/170)) and ([#171](https://github.com/PostHog/posthog-ios/pull/171))
 
 ## 3.7.2 - 2024-08-16

diff --git a/PostHog/PostHogSDK.swift b/PostHog/PostHogSDK.swift
@@ -313,6 +313,7 @@ let maxRetryDelay = 30.0
         replayQueue?.clear()
         flagCallReported.removeAll()
         PostHogSessionManager.shared.endSession()
+        PostHogSessionManager.shared.startSession()
     }
 
     private func getGroups() -> [String: String] {

diff --git a/PostHogTests/PostHogSDKTest.swift b/PostHogTests/PostHogSDKTest.swift
@@ -666,7 +666,7 @@ class PostHogSDKTest: QuickSpec {
             sut.close()
         }
 
-        it("clears sessionId after reset") {
+        it("reset sessionId after reset") {
             let sut = self.getSut(captureApplicationLifecycleEvents: true, flushAt: 1)
             let mockNow = MockDate()
             now = { mockNow.date }
@@ -676,7 +676,8 @@ class PostHogSDKTest: QuickSpec {
             var events = getBatchedEvents(server)
             expect(events.count) == 1
 
-            expect(events[0].properties["$session_id"] as? String).toNot(beNil())
+            let currentSessionId = events[0].properties["$session_id"] as? String
+            expect(currentSessionId).toNot(beNil())
 
             sut.reset()
 
@@ -690,7 +691,10 @@ class PostHogSDKTest: QuickSpec {
             events = getBatchedEvents(server)
             expect(events.count) == 1
 
-            expect(events[0].properties["$session_id"] as? String).to(beNil())
+            let newSessionId = events[0].properties["$session_id"] as? String
+            expect(newSessionId).toNot(beNil())
+
+            expect(currentSessionId).toNot(equal(newSessionId))
 
             sut.reset()
             sut.close()