Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): Render feedback preview #1030

Merged
merged 6 commits into from
Feb 20, 2024
Merged

fix(surveys): Render feedback preview #1030

merged 6 commits into from
Feb 20, 2024

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Feb 20, 2024

Changes

  1. Adds support for feedback widget previews
  2. Fixes a major issue when loading survey preview methods for feat(surveys): replace surveys preview posthog#20321 where generateSurveys from the modules file was overriding the generateSurveys that we want from the iife file, causing callSurveys to not show surveys normally. So we have to either split them up into separate loader files or find a way to distinguish moment in time which script is calling loader-surveys 🤔

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@liyiy liyiy requested a review from neilkakkar February 20, 2024 02:55
Copy link

Size Change: -70.3 kB (-8%) ✅

Total Size: 854 kB

Filename Size Change
dist/surveys.esm.js 0 B -64.2 kB (removed) 🏆
dist/surveys.js 58.3 kB -6.03 kB (-9%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 183 kB
dist/array.js 125 kB
dist/es.js 125 kB
dist/exception-autocapture.js 12 kB
dist/module.js 125 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.6 kB
dist/surveys-module-previews.js 62 kB

compressed-size-action

@liyiy liyiy requested a review from benjackwhite February 20, 2024 02:58
@liyiy liyiy added the bump minor Bump minor version when this PR gets merged label Feb 20, 2024
@liyiy liyiy merged commit 1b5632d into main Feb 20, 2024
15 checks passed
@liyiy liyiy deleted the render-feedback-preview branch February 20, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants