feat(surveys): replace surveys preview #20321

liyiy · 2024-02-13T19:32:29Z

Problem

Changes

remake of #20280

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

(cherry picked from commit 872000f)

…nto update-preview

posthog-bot · 2024-02-15T18:43:41Z

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

chromium: 0 added, 28 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T20:56:25Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T21:05:17Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T21:14:08Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T21:23:04Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…nto update-preview

jurajmajerik · 2024-04-26T10:19:38Z

Changes:

Fixed guardAvailableFeature used for triggering subscription modal (was moved to another logic in the meantime)
Removed e2e test for the open-ended answer choice. This field is currently not getting auto-selected on text input, which is not a great UX, but we can live with it for a bit longer. Fixing this is beyond the scope of this sprint, but I've created an issue for it.
Adjusted rendering (see fix(surveys): use correct render method posthog-js#1157)

posthog-bot · 2024-04-26T10:28:40Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-26T10:38:48Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

neilkakkar · 2024-04-26T11:46:58Z

One blocking thing I mentioned in the other PR: The preview hides the 'save as draft' button. Otherwise, will give it a final test once the other PR is merged, should be ready to go right after 👍

jurajmajerik · 2024-04-29T11:46:49Z

Ready for the final check!

posthog-bot · 2024-04-29T11:57:05Z

📸 UI snapshots have been updated

13 snapshot changes in total. 0 added, 13 modified, 0 deleted:

chromium: 0 added, 13 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…nto update-preview

neilkakkar · 2024-04-29T12:05:33Z

Nice!

Long names bork preview ->

.whitespace-nowrap seems to be the sus class

html links seem to show up red in the preview for some reason -> - ah most probs because posthog styles override the preview styles

We should center the preview ->

CSAT emojis look nicer on prod -> (this is prod)

and local ->

Seems pretty good other than this 👍

posthog-bot · 2024-04-29T12:07:29Z

📸 UI snapshots have been updated

12 snapshot changes in total. 0 added, 12 modified, 0 deleted:

chromium: 0 added, 12 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

jurajmajerik · 2024-04-29T13:56:37Z

I've fixed the alignment issues. Can we leave the color of the CSAT emoji for a follow-up? It seems it has to do with how we're attaching stylesheets, but debugging in the current workflow is 😩

I've confirmed the colors in the edit form and in the live survey are working correctly.

neilkakkar · 2024-04-29T14:07:36Z

frontend/src/lib/utils.tsx

        }
+        return '-inf'


is this based on master correctly 🤔 , iirc this if-else change should already be in master

it seems not? https://github.com/PostHog/posthog/blob/master/frontend/src/lib/utils.tsx#L421

neilkakkar · 2024-04-29T14:09:57Z

frontend/src/scenes/surveys/SurveyEditQuestionRow.tsx

                            },
                            {
                                label: 'Rating',
                                value: SurveyQuestionType.Rating,
-                                tooltip: () => (
-                                    <SurveyRatingAppearance


oh interesting, we're removing these, but would be nice to bring back in a future refactor. I'm assuming this was removed because the preview is now coming from the js package

Issue created: #21941

neilkakkar · 2024-04-29T14:12:48Z

cypress/e2e/surveys.cy.ts

@@ -168,60 +167,6 @@ describe('Surveys', () => {
        cy.get('.Toastify__toast-body').contains('Survey deleted').should('be.visible')
    })

-    it('creates a new multiple choice survey with an open-ended choice', () => {


don't remember the context for deleting this, but if its something to be fixed in the future, can we instead do it.skip() ?

I've created an issue and saved the deleted test in a Gist attached: #21877

But it.skip() is handy, will keep in mind for the next time 👍

liyiy added 6 commits February 13, 2024 14:31

use posthog js surveys preview

518efde

(cherry picked from commit 872000f)

replace for survey templates

8111118

rename survey appearance

fb26a6e

update import

1dd3183

fix

15eb56a

add surveys plugin to storybook test

b1070ff

liyiy requested a review from neilkakkar February 14, 2024 16:23

liyiy added 5 commits February 14, 2024 11:23

Merge branch 'master' into update-preview

005b0cb

Merge branch 'master' into update-preview

03a7cc2

Merge branch 'master' into update-preview

65abfd7

remove plugin add

bc18281

Merge branch 'update-preview' of https://github.com/PostHog/posthog i…

88df97d

…nto update-preview

liyiy requested a review from jurajmajerik February 15, 2024 18:33

github-actions bot added 2 commits February 15, 2024 18:40

Update UI snapshots for chromium (1)

f93703b

Update UI snapshots for chromium (2)

56cf42d

liyiy and others added 2 commits February 15, 2024 15:47

Merge branch 'master' into update-preview

faaac7b

Update UI snapshots for webkit (2)

aace01f

Update UI snapshots for webkit (2)

2e1c138

Update UI snapshots for webkit (2)

732f19c

Update UI snapshots for webkit (2)

7ed17a6

liyiy added 2 commits February 19, 2024 14:33

Merge branch 'master' into update-preview

98313a9

add feedback widget preview

559e434

liyiy mentioned this pull request Feb 20, 2024

fix(surveys): Render feedback preview PostHog/posthog-js#1030

Merged

3 tasks

liyiy added 2 commits February 19, 2024 21:54

fix import path

a26fd24

Merge branch 'update-preview' of https://github.com/PostHog/posthog i…

d790481

…nto update-preview

jurajmajerik mentioned this pull request Apr 26, 2024

fix(surveys): use correct render method PostHog/posthog-js#1157

Merged

3 tasks

adjust preview rendering

211ec3e

jurajmajerik requested review from neilkakkar and removed request for neilkakkar April 26, 2024 10:19

Update UI snapshots for chromium (2)

6f4154b

Update UI snapshots for chromium (2)

6441486

jurajmajerik added 2 commits April 29, 2024 13:37

fix conflict

dbf1762

adjust survey preview

17384a0

github-actions bot added 2 commits April 29, 2024 11:55

Update UI snapshots for chromium (1)

960ce5a

Update UI snapshots for chromium (2)

97d7998

jurajmajerik added 2 commits April 29, 2024 13:57

don't use margins on the wrapping div, this needs a better fix

7032dd8

Merge branch 'update-preview' of https://github.com/PostHog/posthog i…

300771f

…nto update-preview

github-actions bot added 2 commits April 29, 2024 12:05

Update UI snapshots for chromium (1)

cc2862f

Update UI snapshots for chromium (2)

37ff74c

Merge branch 'master' into update-preview

f61985d

neilkakkar approved these changes Apr 29, 2024

View reviewed changes

neilkakkar reviewed Apr 29, 2024

View reviewed changes

jurajmajerik merged commit 43c5c9f into master Apr 29, 2024
103 checks passed

jurajmajerik deleted the update-preview branch April 29, 2024 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(surveys): replace surveys preview #20321

feat(surveys): replace surveys preview #20321

liyiy commented Feb 13, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

jurajmajerik commented Apr 26, 2024

posthog-bot commented Apr 26, 2024

posthog-bot commented Apr 26, 2024

neilkakkar commented Apr 26, 2024

jurajmajerik commented Apr 29, 2024

posthog-bot commented Apr 29, 2024

neilkakkar commented Apr 29, 2024 •

edited

Loading

posthog-bot commented Apr 29, 2024

jurajmajerik commented Apr 29, 2024

neilkakkar Apr 29, 2024

jurajmajerik Apr 29, 2024

neilkakkar Apr 29, 2024

jurajmajerik Apr 29, 2024

neilkakkar Apr 29, 2024

jurajmajerik Apr 29, 2024

neilkakkar Apr 29, 2024

feat(surveys): replace surveys preview #20321

feat(surveys): replace surveys preview #20321

Conversation

liyiy commented Feb 13, 2024

Problem

Changes

How did you test this code?

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

jurajmajerik commented Apr 26, 2024

posthog-bot commented Apr 26, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 26, 2024

📸 UI snapshots have been updated

neilkakkar commented Apr 26, 2024

jurajmajerik commented Apr 29, 2024

posthog-bot commented Apr 29, 2024

📸 UI snapshots have been updated

neilkakkar commented Apr 29, 2024 • edited Loading

posthog-bot commented Apr 29, 2024

📸 UI snapshots have been updated

jurajmajerik commented Apr 29, 2024

neilkakkar Apr 29, 2024

Choose a reason for hiding this comment

jurajmajerik Apr 29, 2024

Choose a reason for hiding this comment

neilkakkar Apr 29, 2024

Choose a reason for hiding this comment

jurajmajerik Apr 29, 2024

Choose a reason for hiding this comment

neilkakkar Apr 29, 2024

Choose a reason for hiding this comment

jurajmajerik Apr 29, 2024

Choose a reason for hiding this comment

neilkakkar Apr 29, 2024

Choose a reason for hiding this comment

neilkakkar commented Apr 29, 2024 •

edited

Loading