fix(surveys): use correct render method #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -4.35 kB (0%) Total Size: 971 kB
ℹ️ View Unchanged
|
jurajmajerik
requested review from
benjackwhite and
neilkakkar
and removed request for
benjackwhite
benjackwhite
approved these changes
Apr 26, 2024
|
Makes sense 👍 . Heads up for the companion PR / cleanup, that the margins are off: |
neilkakkar
reviewed
Apr 26, 2024
| @@ -320,40 +315,66 @@ export function Questions({ | |||
| setCurrentQuestion(idx + 1) | |||
| } | |||
| } | |||
| const isMultipleQuestion = survey.questions.length > 1 | |||
|
|
|||
| const questionToDisplay = readOnly ? previewQuestionIndex : currentQuestion | |||
There was a problem hiding this comment.
A bit annoying that in the main code we have to have special handling for previews, I expect this will become a lot more annoying when you need actual functionality with the branching logic for example.
There was a problem hiding this comment.
💯 , I want to clean this up
This was referenced May 22, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In PostHog/posthog#20321, surveys are rendered using
preact-render-to-string. This method renders plain HTML, stripping any event listeners. Because of this, some interactions were not working (I had missed this in the initial review - my bad).Changes
Preact.renderfor rendering previewsThis needs a much bigger cleanup, but annoying to do with the current slow iteration cycle - want to set up a better environment first. But this will get us over the line with PostHog/posthog#20321
This change should be merged together with PostHog/posthog#20321
Test
Screen.Recording.2024-04-26.at.12.14.54.mov
Checklist