Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): replace surveys preview #20321

Merged
merged 47 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
518efde
use posthog js surveys preview
liyiy Feb 10, 2024
8111118
replace for survey templates
liyiy Feb 11, 2024
fb26a6e
rename survey appearance
liyiy Feb 11, 2024
1dd3183
update import
liyiy Feb 13, 2024
15eb56a
fix
liyiy Feb 13, 2024
b1070ff
add surveys plugin to storybook test
liyiy Feb 13, 2024
005b0cb
Merge branch 'master' into update-preview
liyiy Feb 14, 2024
03a7cc2
Merge branch 'master' into update-preview
liyiy Feb 14, 2024
65abfd7
Merge branch 'master' into update-preview
liyiy Feb 15, 2024
bc18281
remove plugin add
liyiy Feb 15, 2024
88df97d
Merge branch 'update-preview' of https://github.com/PostHog/posthog i…
liyiy Feb 15, 2024
f93703b
Update UI snapshots for `chromium` (1)
github-actions[bot] Feb 15, 2024
56cf42d
Update UI snapshots for `chromium` (2)
github-actions[bot] Feb 15, 2024
faaac7b
Merge branch 'master' into update-preview
liyiy Feb 15, 2024
aace01f
Update UI snapshots for `webkit` (2)
github-actions[bot] Feb 15, 2024
2e1c138
Update UI snapshots for `webkit` (2)
github-actions[bot] Feb 15, 2024
732f19c
Update UI snapshots for `webkit` (2)
github-actions[bot] Feb 15, 2024
7ed17a6
Update UI snapshots for `webkit` (2)
github-actions[bot] Feb 15, 2024
98313a9
Merge branch 'master' into update-preview
liyiy Feb 19, 2024
559e434
add feedback widget preview
liyiy Feb 19, 2024
a26fd24
fix import path
liyiy Feb 20, 2024
d790481
Merge branch 'update-preview' of https://github.com/PostHog/posthog i…
liyiy Feb 20, 2024
d4e199e
fix types
liyiy Feb 21, 2024
595d531
Merge branch 'master' into update-preview
liyiy Feb 21, 2024
07df20d
Merge branch 'master' into update-preview
liyiy Feb 21, 2024
471b824
Update UI snapshots for `chromium` (2)
github-actions[bot] Feb 21, 2024
5825792
fix e2e test
liyiy Feb 21, 2024
4892ee1
Merge branch 'update-preview' of https://github.com/PostHog/posthog i…
liyiy Feb 21, 2024
964f98b
Merge branch 'master' into update-preview
jurajmajerik Feb 29, 2024
5820a1f
fix conflict
jurajmajerik Apr 25, 2024
d5b1b9a
Update UI snapshots for `chromium` (1)
github-actions[bot] Apr 25, 2024
597b0b0
Update UI snapshots for `chromium` (2)
github-actions[bot] Apr 25, 2024
8f72600
fix feature guarding
jurajmajerik Apr 25, 2024
f7e18e9
Merge branch 'update-preview' of https://github.com/PostHog/posthog i…
jurajmajerik Apr 25, 2024
da00472
remove open-choice test
jurajmajerik Apr 26, 2024
211ec3e
adjust preview rendering
jurajmajerik Apr 26, 2024
6f4154b
Update UI snapshots for `chromium` (2)
github-actions[bot] Apr 26, 2024
6441486
Update UI snapshots for `chromium` (2)
github-actions[bot] Apr 26, 2024
dbf1762
fix conflict
jurajmajerik Apr 29, 2024
17384a0
adjust survey preview
jurajmajerik Apr 29, 2024
960ce5a
Update UI snapshots for `chromium` (1)
github-actions[bot] Apr 29, 2024
97d7998
Update UI snapshots for `chromium` (2)
github-actions[bot] Apr 29, 2024
7032dd8
don't use margins on the wrapping div, this needs a better fix
jurajmajerik Apr 29, 2024
300771f
Merge branch 'update-preview' of https://github.com/PostHog/posthog i…
jurajmajerik Apr 29, 2024
cc2862f
Update UI snapshots for `chromium` (1)
github-actions[bot] Apr 29, 2024
37ff74c
Update UI snapshots for `chromium` (2)
github-actions[bot] Apr 29, 2024
f61985d
Merge branch 'master' into update-preview
jurajmajerik Apr 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-surveys--new-survey--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-surveys--new-survey--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 5 additions & 6 deletions frontend/src/scenes/notebooks/Nodes/NotebookNodeSurvey.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ import { notebookNodeLogic } from './notebookNodeLogic'
import { JSONContent, NotebookNodeProps } from '../Notebook/utils'
import { buildFlagContent } from './NotebookNodeFlag'
import { surveyLogic } from 'scenes/surveys/surveyLogic'
import { defaultSurveyAppearance } from 'scenes/surveys/constants'
import { StatusTag } from 'scenes/surveys/Surveys'
import { SurveyResult } from 'scenes/surveys/SurveyView'
import { SurveyAppearance } from 'scenes/surveys/SurveyAppearance'
import { SurveyReleaseSummary } from 'scenes/surveys/Survey'
import { useEffect } from 'react'
import { NotFound } from 'lib/components/NotFound'
import { SurveyAppearancePreview } from 'scenes/surveys/SurveyAppearancePreview'

const Component = ({ attributes }: NotebookNodeProps<NotebookNodeSurveyAttributes>): JSX.Element => {
const { id } = attributes
Expand Down Expand Up @@ -77,10 +76,10 @@ const Component = ({ attributes }: NotebookNodeProps<NotebookNodeSurveyAttribute
<SurveyReleaseSummary id={id} survey={survey} hasTargetingFlag={hasTargetingFlag} />

<div className="w-full flex flex-col items-center">
<SurveyAppearance
surveyType={survey.type}
surveyQuestionItem={survey.questions[0]}
appearance={survey.appearance || defaultSurveyAppearance}
<SurveyAppearancePreview
survey={survey}
activePreview="survey"
questionIndex={0}
/>
</div>
</div>
Expand Down
332 changes: 0 additions & 332 deletions frontend/src/scenes/surveys/SurveyAppearance.scss

This file was deleted.

Loading
Loading