feat(surveys): replace surveys preview with posthog-js source of truth #20280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated28 snapshot changes in total. 0 added, 28 modified, 0 deleted:
Triggered by this commit. |
3 tasks
liyiy
force-pushed
the
update-surveys-preview
branch
from
cb29245 to
0d7b6f8
Compare
liyiy
force-pushed
the
update-surveys-preview
branch
from
0d7b6f8 to
7234fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were duplicating surveys popup UI code for the in app preview. Having multiple renditions of the popup is hard to maintain and we needed to refactor it to use posthog-js's as the source of truth for the preview
Changes
Screen.Recording.2024-02-12.at.1.56.49.PM.mov
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?