Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Heatmaps instrumentation #1131

Merged
merged 43 commits into from
Apr 18, 2024
Merged

feat: Heatmaps instrumentation #1131

merged 43 commits into from
Apr 18, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Apr 10, 2024 •
edited
Loading

Changes

Needs PostHog/posthog#21598
Needs PostHog/posthog#21487

Adds a new Heatmaps class that takes care of extra telemetry for improved heatmaps

TODO:

  • Don't track clicks from the toolbar

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite changed the title Feat/heatmaps part2 feat: Heatmaps instrumentation Apr 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Size Change: +5.46 kB (+1%)

Total Size: 967 kB

Filename Size Change
dist/array.full.js 231 kB +1.37 kB (+1%)
dist/array.js 129 kB +1.36 kB (+1%)
dist/es.js 129 kB +1.36 kB (+1%)
dist/exception-autocapture.js 12.2 kB +15 B (0%)
dist/module.js 129 kB +1.36 kB (+1%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

pauldambra
pauldambra approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/heatmaps.ts Show resolved Hide resolved
src/page-view.ts Show resolved Hide resolved
@benjackwhite benjackwhite marked this pull request as ready for review April 15, 2024 07:23
Base automatically changed from feat/heatmaps to main April 15, 2024 10:16
@benjackwhite
Added skipping for heatmaps on snapshots
a6f548b
@benjackwhite
Merge branch 'main' into feat/heatmaps-part2
dc260f8 
# Conflicts:
#	playground/nextjs/pages/_app.tsx
#	src/__tests__/autocapture.test.ts
#	src/__tests__/decide.js
#	src/autocapture.ts
#	src/decide.ts
#	src/posthog-core.ts
@benjackwhite
fix
d46b885
@benjackwhite
Fixes
0cbf653
@benjackwhite
Fixes
c79d24c
@benjackwhite
fix
b18767a
@benjackwhite
fix
c2f13a2
This was referenced Apr 18, 2024
Merged
Merged
@benjackwhite benjackwhite added the bump minor Bump minor version when this PR gets merged label Apr 18, 2024
@benjackwhite benjackwhite merged commit ba1b431 into main Apr 18, 2024
11 checks passed
@benjackwhite benjackwhite deleted the feat/heatmaps-part2 branch April 18, 2024 11:21
This was referenced May 20, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged heatmaps-in-the-heat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @pauldambra