-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Heatmaps ingestion #21629
feat: Heatmaps ingestion #21629
Conversation
plugin-server/src/worker/ingestion/event-pipeline/extractHeatmapDataStep.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't run it but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, the fact that it's in a try/catch and uses the existing ack system should mean it's safe. 👍
One thing I'm curious about: is this part of a JS SDK change that we'll just flip on for all autocapture events or something? The test heatmap data looks kind of large, is that representative? Can they be larger? Is there a limit or any protection in the SDK? I'm mostly wondering about data volume changes flowing through capture and multiple Kafka topics and whether we need to consider that all.
I don't have anything particular to worry about, it just got my spidey sense tingling.
maybe possibly. We have it as a JS change and it could indeed end up being a half decent amount of data. It is however client side flagged currently so we will be testing it just for our team for starters so we can get a better sense of how the data flow goes. I think I'll add a server-side setting for it as well so that we can control it remotely to give us a little more reaction if we do end up seeing worrying sizes. |
Problem
Ingestion part of #21487
Related API PR #21623
Related JS PR PostHog/posthog-js#1131
Changes
$heatmaps_data
property👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?