Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pause error patch #22060

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: pause error patch #22060

merged 1 commit into from
May 3, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented May 3, 2024

Problem

#21874

Changes

Applies patch suggested in rrweb-io/rrweb#1462

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto
Copy link
Member

@daibhin should we remove this patch now #21898 ?

@marandaneto
Copy link
Member

Shouldn't the patches live in the SDK instead? https://github.com/PostHog/posthog-js/tree/main/patches

@daibhin daibhin merged commit 7c6805d into master May 3, 2024
97 checks passed
@daibhin daibhin deleted the dn-fix/pause-error branch May 3, 2024 10:17
@daibhin
Copy link
Contributor Author

daibhin commented May 3, 2024

@marandaneto I typically remove the patches when we upgrade the version. That one we probably could remove but it's not doing any harm either.

We actually have patches in two places 😓 Because we don't have a fork we apply patches depending on whether it is a recording or playback issue (in this case it's playback so the posthog repo)

@marandaneto
Copy link
Member

@marandaneto I typically remove the patches when we upgrade the version. That one we probably could remove but it's not doing any harm either.

We actually have patches in two places 😓 Because we don't have a fork we apply patches depending on whether it is a recording or playback issue (in this case it's playback so the posthog repo)

Ahhh that makes sense, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants