Fix media replay bug when target is not an AUDIO or VIDEO element #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially fixes PostHog/posthog#21874 And potentially fixes #1461
🦋 Changeset detectedLatest commit: 86baaba The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
marandaneto
reviewed
May 2, 2024
| @@ -272,6 +272,8 @@ export class MediaManager { | |||
| timeOffset: number; | |||
| mutation: mediaInteractionData; | |||
| }) { | |||
| if (!['AUDIO', 'VIDEO'].includes(target.nodeName)) return; | |||
There was a problem hiding this comment.
addMediaElements already does this check so it's not hurting.
addMediaElements is only called if isSupportedMediaElement returns true, which does the very same check.
Most likely the addMediaElements could remove this line
mediaMutation is the only method besides addMediaElements that mutates mediaMap without this check so the change makes sense to me, we can reuse the isSupportedMediaElement method though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes PostHog/posthog#21874
Replacement for #1461