Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade python to 3.11 🐍 #22932

Merged
merged 48 commits into from
Jun 21, 2024
Merged

chore: upgrade python to 3.11 🐍 #22932

merged 48 commits into from
Jun 21, 2024

Conversation

aspicer
Copy link
Contributor

@aspicer aspicer commented Jun 12, 2024

Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite.

'nuff said.

Steps to get this working are as such:

brew install python@3.11
rm -rf env
python3.11 -m venv env
. env/bin/activate
pip install uv
uv pip install -r requirements.txt -r requirements-dev.txt

List of Changes

@aspicer aspicer changed the title wip testing chore: upgrade python to 3.11 🐍 Jun 14, 2024
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@aspicer aspicer marked this pull request as ready for review June 14, 2024 07:45
@webjunkie webjunkie self-requested a review June 18, 2024 08:03
@fuziontech
Copy link
Member

fuziontech commented Jun 18, 2024

looks like one other spot to bump the Python version
https://github.com/PostHog/posthog/blob/2f10422600704f6046b773c26cd876abf04032e4/Dockerfile#L86

IGNORE ME - fooled by a symlink

@fuziontech
Copy link
Member

wrt the hobby deploy - I'll fix that after this lands. Will probably require some attention.

@frankh frankh added the canary label Jun 21, 2024
@aspicer aspicer enabled auto-merge (squash) June 21, 2024 16:30
@aspicer aspicer merged commit 23a789d into master Jun 21, 2024
86 of 87 checks passed
@aspicer aspicer deleted the aspicer/3.11 branch June 21, 2024 16:45
thmsobrmlr pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants