Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade python to 3.11 #23206

Merged
merged 16 commits into from
Jun 27, 2024
Merged

chore: upgrade python to 3.11 #23206

merged 16 commits into from
Jun 27, 2024

Conversation

aspicer
Copy link
Contributor

@aspicer aspicer commented Jun 24, 2024

Reverting the revert. The issues that arose are around social-auth and xmlsec.

This diff reverts xmlsec and lxml to the previous version and builds them from scratch.

Verified this works for SAML. Good to go.

Deploy Plan
Deploy to Canary, roll out in US, test SAML, then proceed or roll back.

Revert:
#23198

Original:
#22932

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@aspicer aspicer marked this pull request as ready for review June 26, 2024 17:01
Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there's no mis-match errors for xmlsec and you didn't change any xmlsec / lxml versions, this feels safe.

@aspicer aspicer added the canary label Jun 27, 2024
@aspicer aspicer merged commit eac199d into master Jun 27, 2024
92 checks passed
@aspicer aspicer deleted the aspicer/3.11take2 branch June 27, 2024 21:16
Phanatic pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants