feat(surveys): added a customizable submit button text color #24170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
commented
Aug 2, 2024
| <LemonInput | ||
| value={appearance?.placeholder || defaultSurveyAppearance.placeholder} | ||
| onChange={(placeholder) => onAppearanceChange({ ...appearance, placeholder })} | ||
| disabled={!surveysStylingAvailable} | ||
| /> | ||
| </> | ||
| )} | ||
| <div className="mt-2"> | ||
| <div className="mt-4"> |
There was a problem hiding this comment.
noticed that the customization elements seemed too crowded; added a little space here to let the different parts breathe.
Before:
After:
dmarticus
commented
Aug 2, 2024
| {surveyQuestionItem.type === SurveyQuestionType.Open && ( | ||
| <> | ||
| <div className="mt-2">Placeholder</div> | ||
| <div className="mt-2">Placeholder text</div> |
There was a problem hiding this comment.
imo this is clearer than just saying "Placeholder"
| @@ -164,6 +164,7 @@ const surveyActionsMapping: Record< | |||
| backgroundColor: 'background color', | |||
| submitButtonColor: 'submit button color', | |||
| submitButtonText: 'submit button text', | |||
| submitButtonTextColor: 'submit button text color', | |||
There was a problem hiding this comment.
added to the activity log
| @@ -32,6 +32,7 @@ export const SurveyUrlMatchTypeLabels = { | |||
| export const defaultSurveyAppearance = { | |||
| backgroundColor: '#eeeded', | |||
| submitButtonColor: 'black', | |||
| submitButtonTextColor: 'white', | |||
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
…om:PostHog/posthog into feat/modify-submit-button-text-for-surveys
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
…#24170) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hospitable asked for this, and it was super easy to do. Feels worth it.
Ships with the posthog-js changes here: PostHog/posthog-js#1339
Video demo: https://www.loom.com/share/07e3409daded4bf4908442286a88b009?sid=a7c6d250-bb82-4ce0-905c-cc89a7d20716