-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(surveys): added a customizable submit button text color #24170
Changes from 1 commit
4563a36
1fe8fc1
4256a62
2a266dd
293ae9f
db6c64b
89dafa0
74e2eda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,17 +99,23 @@ export function Customization({ appearance, surveyQuestionItem, onAppearanceChan | |
onChange={(submitButtonColor) => onAppearanceChange({ ...appearance, submitButtonColor })} | ||
disabled={!surveysStylingAvailable} | ||
/> | ||
<div className="mt-2">Button text color</div> | ||
<LemonInput | ||
value={appearance?.submitButtonTextColor} | ||
onChange={(submitButtonTextColor) => onAppearanceChange({ ...appearance, submitButtonTextColor })} | ||
disabled={!surveysStylingAvailable} | ||
/> | ||
{surveyQuestionItem.type === SurveyQuestionType.Open && ( | ||
<> | ||
<div className="mt-2">Placeholder</div> | ||
<div className="mt-2">Placeholder text</div> | ||
<LemonInput | ||
value={appearance?.placeholder || defaultSurveyAppearance.placeholder} | ||
onChange={(placeholder) => onAppearanceChange({ ...appearance, placeholder })} | ||
disabled={!surveysStylingAvailable} | ||
/> | ||
</> | ||
)} | ||
<div className="mt-2"> | ||
<div className="mt-4"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<LemonCheckbox | ||
label={ | ||
<div className="flex items-center"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ export const SurveyUrlMatchTypeLabels = { | |
export const defaultSurveyAppearance = { | ||
backgroundColor: '#eeeded', | ||
submitButtonColor: 'black', | ||
submitButtonTextColor: 'white', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default |
||
ratingButtonColor: 'white', | ||
ratingButtonActiveColor: 'black', | ||
borderColor: '#c9c6c6', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,6 +164,7 @@ const surveyActionsMapping: Record< | |
backgroundColor: 'background color', | ||
submitButtonColor: 'submit button color', | ||
submitButtonText: 'submit button text', | ||
submitButtonTextColor: 'submit button text color', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added to the activity log |
||
ratingButtonColor: 'rating button color', | ||
ratingButtonActiveColor: 'active rating button color', | ||
borderColor: 'border color', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this is clearer than just saying "Placeholder"