Handle empty content-type from IE11 in capture endpoint #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
macobo
force-pushed
the
capture-contenttype-ie11
branch
from
30f925d to
b35a67a
Compare
When posting gzipped data from posthog-js (gzip-js), all browsers except IE11 send content-type as 'text/plain'. IE11 has a bug (jimmywarting/FormData#44) where it fails to do that, causing us to dismiss these events. This only occurs when using bin/docker-server and not bin/start-backend. Related PR: PostHog/posthog-js#180
macobo
force-pushed
the
capture-contenttype-ie11
branch
from
b35a67a to
926177d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When posting gzipped data from posthog-js (gzip-js), all browsers except
IE11 send content-type as 'text/plain'. IE11 has a bug
(jimmywarting/FormData#44) where it fails to
do that, causing us to dismiss these events.
This only occurs when using bin/docker-server and not bin/start-backend.
Related PR: PostHog/posthog-js#180
Checklist